rustdoc: remove weird <a href="#"> wrapper around unsafe triangle#102524
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 9, 2022
Merged
rustdoc: remove weird <a href="#"> wrapper around unsafe triangle#102524bors merged 2 commits intorust-lang:masterfrom
<a href="#"> wrapper around unsafe triangle#102524bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
Member
|
Can you add a GUI test for the color and height please? |
2ebc8f1 to
40998cf
Compare
Contributor
Author
|
@GuillaumeGomez Okay, test case added. |
GuillaumeGomez
approved these changes
Oct 8, 2022
Member
|
Thanks! r=me once CI pass |
This DOM cleanup changes the color of the triangle, from blue to black, but since it's still a different color from the link it's next to, it should still be noticeable.
40998cf to
bf510b4
Compare
Contributor
Author
|
@bors r=GuillaumeGomez rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#99194 (Fix gdb-cmd for rust-gdbgui) - rust-lang#99880 (`EscapeAscii` is not an `ExactSizeIterator`) - rust-lang#102524 (rustdoc: remove weird `<a href="#">` wrapper around unsafe triangle) - rust-lang#102581 (Make the `config.src` handling for downloadable bootstrap more conservative) - rust-lang#102604 (Improve readability of bootstrap's README) - rust-lang#102723 (test: run-make: skip when cross-compiling) - rust-lang#102815 (rustdoc: remove mobile topbar from source pages instead of hiding it) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This DOM cleanup changes the color of the triangle, from blue to black, but since it's still a different color from the link it's next to, it should still be noticeable.
Before
After