Merged
Conversation
…re conservative In particular, this supports build directories within an unrelated git repository. As a side effect, it will fall back to the old logic when the source directory is being built from a tarball within an unrelated git repository. However, that second case is unsupported and untested; we reserve the right to break it in the future.
…changes (cherry picked from commit e5e4b85feba6463310d0fc0c27e8ff38891efac3)
This test fails when targeting aarch64 Android. Instead of adding yet another architecture here (and one that's increasingly more common as the host), let's replace the growing list of architectures with ignore-cross-compile.
This DOM cleanup changes the color of the triangle, from blue to black, but since it's still a different color from the link it's next to, it should still be noticeable.
…b-args-to-gdb-cmd, r=Mark-Simulacrum Fix gdb-cmd for rust-gdbgui With cs01/gdbgui#198, the way that gdbgui arguments were specified changed. I've tested this with program generated from `cargo new --bin` and it worked as gdbgui should. Closes rust-lang#76383.
…-exact-size-iterator, r=thomcc `EscapeAscii` is not an `ExactSizeIterator` Fixes rust-lang#99878 Do we want/need `EscapeAscii` to be an `ExactSizeIterator`? I guess we could precompute the length of the output if so?
…n, r=GuillaumeGomez rustdoc: remove weird `<a href="#">` wrapper around unsafe triangle This DOM cleanup changes the color of the triangle, from blue to black, but since it's still a different color from the link it's next to, it should still be noticeable. # Before  # After 
…acrum Make the `config.src` handling for downloadable bootstrap more conservative In particular, this supports build directories within an unrelated git repository. Fixes rust-lang#102562. As a side effect, it will fall back to the old logic when the source directory is being built from a tarball within an unrelated git repository. However, that second case is unsupported and untested; we reserve the right to break it in the future. `@cr1901` can you confirm this fixes your problem? cc `@kleisauke,` I believe this will also fix your issue (although your use case still isn't supported). r? `@Mark-Simulacrum`
…trap_readme_readability, r=Mark-Simulacrum Improve readability of bootstrap's README Improve readability of bootstrap's README by adding commas & minor changes
test: run-make: skip when cross-compiling This test fails when targeting aarch64 Android. Instead of adding yet another architecture here (and one that's increasingly more common as the host), let's replace the growing list of architectures with ignore-cross-compile.
… r=GuillaumeGomez rustdoc: remove mobile topbar from source pages instead of hiding it
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 8796e7a9cf In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (f382c27): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
EscapeAsciiis not anExactSizeIterator#99880 (EscapeAsciiis not anExactSizeIterator)<a href="#">wrapper around unsafe triangle #102524 (rustdoc: remove weird<a href="#">wrapper around unsafe triangle)config.srchandling for downloadable bootstrap more conservative #102581 (Make theconfig.srchandling for downloadable bootstrap more conservative)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup