Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Thanks for working on this!

I'll take a more in-depth look soon, but why did this add core::cmp to Eq and PartialEq? If it is related to rustc-dep-of-std then that can be disregarded, we don't need to support both rustc-dep-of-std and extra-traits being enabled at the same time.

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Some changes occurred in OpenBSD module

cc @semarie

Fyi the current error comes from a new lint in a recent nightly, I'll have it fixed soon #4177

Feel free to cherry pick 99f4dd9 so you get CI results now, I can rebase once things turn green.