Allow the unpredictable_function_pointer_comparisons where needed#4177
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Dec 7, 2024
Merged
Allow the unpredictable_function_pointer_comparisons where needed#4177tgross35 merged 1 commit intorust-lang:mainfrom
unpredictable_function_pointer_comparisons where needed#4177tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
This lint was recently added so this change is needed to fix CI. The suggested alternative is to use `ptr::fn_addr_eq` which isn't available until 1.85, so allow the lint here.
0ed3881 to
99f4dd9
Compare
unpredictable_function_pointer_comparisons in one placeunpredictable_function_pointer_comparisons where needed
3 tasks
3 tasks
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 9, 2024
This lint was recently added so this change is needed to fix CI. The suggested alternative is to use `ptr::fn_addr_eq` which isn't available until 1.85, so allow the lint here. (backport <rust-lang#4177>) (cherry picked from commit 99f4dd9)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint was recently added so this change is needed to fix CI. The suggested alternative is to use
ptr::fn_addr_eqwhich isn't available until 1.85, so allow the lint here.This is in a
PartialEqfor a union so hopefully this code should go away in 1.0 anyway.