fix(host-config): dont apply target config to host artifacts #17123
Merged
Conversation
With `-Zhost-config`, a host artifact must only take its config from `[host]` but never from `[target.'cfg(...)']`. The first branch of `target_runner` already routes `[host]` and `[target]` correctly. However, later the cfg fallback read the global `target_cfgs()` so a build script wrongly picked up the target's `cfg()` runner. This patch follows the same pattern `extra_args` has used.
With `-Zhost-config`, a host artifact must only take its config from `[host]` but never from `[target.'cfg(...)']`. The first branch of `target_linker` already routes `[host]` and `[target]` correctly. However, later the cfg fallback read the global `target_cfgs()` so a host artifact wrongly picked up the target's `cfg()` linker. This patch follows the same pattern `extra_args` has used.
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Jun 20, 2026
This was referenced Jun 20, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jun 20, 2026
Update cargo submodule 9 commits in 598ab48ec328e3e4f5e4e373d8df7264bc8e27cd..a595d0da21f228b7fdae64d3d5c0e527ea66bb59 2026-06-17 02:39:50 +0000 to 2026-06-20 13:42:59 +0000 - fix(host-config): dont apply target config to host artifacts (rust-lang/cargo#17123) - chore(deps): update msrv to v1.94 (rust-lang/cargo#17121) - test(update): show cross-registry multi-spec precise (rust-lang/cargo#17119) - fix(resolver): hint how to resolve too-new versions (rust-lang/cargo#17118) - fix(add): list too-new versions and how to override (rust-lang/cargo#17117) - feat: `-Zmin-publish-age` (RFC 3923) (rust-lang/cargo#17012) - feat(diag): Support `build.warnings` for cargo lints (rust-lang/cargo#17112) - Remove windows-sys dependencies older than 0.61 (rust-lang/cargo#17115) - fix(install): Run cargo lints like rustc lints (rust-lang/cargo#17107)
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jun 21, 2026
Update cargo submodule 9 commits in 598ab48ec328e3e4f5e4e373d8df7264bc8e27cd..a595d0da21f228b7fdae64d3d5c0e527ea66bb59 2026-06-17 02:39:50 +0000 to 2026-06-20 13:42:59 +0000 - fix(host-config): dont apply target config to host artifacts (rust-lang/cargo#17123) - chore(deps): update msrv to v1.94 (rust-lang/cargo#17121) - test(update): show cross-registry multi-spec precise (rust-lang/cargo#17119) - fix(resolver): hint how to resolve too-new versions (rust-lang/cargo#17118) - fix(add): list too-new versions and how to override (rust-lang/cargo#17117) - feat: `-Zmin-publish-age` (RFC 3923) (rust-lang/cargo#17012) - feat(diag): Support `build.warnings` for cargo lints (rust-lang/cargo#17112) - Remove windows-sys dependencies older than 0.61 (rust-lang/cargo#17115) - fix(install): Run cargo lints like rustc lints (rust-lang/cargo#17107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
With
-Zhost-config,a host artifact must only take its config from
[host]but never from
[target.'cfg(...)'].The bug is that the first branch of
target_{linker,runner}already routes
[host]and[target]correctly.However, later the cfg fallback read the global
target_cfgs()so a host artifact wrongly picked up the target's
cfg()linker.This patch follows the same pattern
extra_argshas used.How to test and review this PR?
Two regression tests are added.
Fixes rust-lang/miri#5101
To test against the repro https://github.com/nazar-pc/miri-5101-reproduction, run