Skip to content

feat(diag): Support build.warnings for cargo lints#17112

Merged
weihanglo merged 6 commits into
rust-lang:masterfrom
epage:build.warnings
Jun 18, 2026
Merged

feat(diag): Support build.warnings for cargo lints#17112
weihanglo merged 6 commits into
rust-lang:masterfrom
epage:build.warnings

Conversation

@epage

@epage epage commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

Part of #12235

I included support in cargo fetch because

  • It would have been annoying to not support allow so I did the little bit more to support deny
  • Since it is parsing the manifests, I guess you could say that is a build step and so the build table can apply

How to test and review this PR?

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler Command-fetch S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2026
@rustbot

rustbot commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

@epage epage mentioned this pull request Jun 18, 2026
20 tasks
Comment thread src/cargo/ops/cargo_fetch.rs

@weihanglo weihanglo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is nice.

View changes since this review

@weihanglo weihanglo added this pull request to the merge queue Jun 18, 2026
Merged via the queue into rust-lang:master with commit 00237aa Jun 18, 2026
28 of 29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2026
@epage epage deleted the build.warnings branch June 19, 2026 15:03
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Jun 20, 2026
Update cargo submodule

8 commits in 598ab48ec328e3e4f5e4e373d8df7264bc8e27cd..71e52e6ef695518c3a7d166fdde0dc3650c2fedd
2026-06-17 02:39:50 +0000 to 2026-06-19 16:23:18 +0000
- chore(deps): update msrv to v1.94 (rust-lang/cargo#17121)
- test(update): show cross-registry multi-spec precise (rust-lang/cargo#17119)
- fix(resolver): hint how to resolve too-new versions (rust-lang/cargo#17118)
- fix(add): list too-new versions and how to override (rust-lang/cargo#17117)
- feat: `-Zmin-publish-age` (RFC 3923) (rust-lang/cargo#17012)
- feat(diag): Support `build.warnings` for cargo lints (rust-lang/cargo#17112)
- Remove windows-sys dependencies older than 0.61 (rust-lang/cargo#17115)
- fix(install): Run cargo lints like rustc lints (rust-lang/cargo#17107)

r? ghost
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Jun 20, 2026
Update cargo submodule

9 commits in 598ab48ec328e3e4f5e4e373d8df7264bc8e27cd..a595d0da21f228b7fdae64d3d5c0e527ea66bb59
2026-06-17 02:39:50 +0000 to 2026-06-20 13:42:59 +0000
- fix(host-config): dont apply target config to host artifacts  (rust-lang/cargo#17123)
- chore(deps): update msrv to v1.94 (rust-lang/cargo#17121)
- test(update): show cross-registry multi-spec precise (rust-lang/cargo#17119)
- fix(resolver): hint how to resolve too-new versions (rust-lang/cargo#17118)
- fix(add): list too-new versions and how to override (rust-lang/cargo#17117)
- feat: `-Zmin-publish-age` (RFC 3923) (rust-lang/cargo#17012)
- feat(diag): Support `build.warnings` for cargo lints (rust-lang/cargo#17112)
- Remove windows-sys dependencies older than 0.61 (rust-lang/cargo#17115)
- fix(install): Run cargo lints like rustc lints (rust-lang/cargo#17107)
@rustbot rustbot added this to the 1.98.0 milestone Jun 20, 2026
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jun 21, 2026
Update cargo submodule

9 commits in 598ab48ec328e3e4f5e4e373d8df7264bc8e27cd..a595d0da21f228b7fdae64d3d5c0e527ea66bb59
2026-06-17 02:39:50 +0000 to 2026-06-20 13:42:59 +0000
- fix(host-config): dont apply target config to host artifacts  (rust-lang/cargo#17123)
- chore(deps): update msrv to v1.94 (rust-lang/cargo#17121)
- test(update): show cross-registry multi-spec precise (rust-lang/cargo#17119)
- fix(resolver): hint how to resolve too-new versions (rust-lang/cargo#17118)
- fix(add): list too-new versions and how to override (rust-lang/cargo#17117)
- feat: `-Zmin-publish-age` (RFC 3923) (rust-lang/cargo#17012)
- feat(diag): Support `build.warnings` for cargo lints (rust-lang/cargo#17112)
- Remove windows-sys dependencies older than 0.61 (rust-lang/cargo#17115)
- fix(install): Run cargo lints like rustc lints (rust-lang/cargo#17107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build-execution Area: anything dealing with executing the compiler Command-fetch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants