Skip to content

feat(lints): Add unused workspace dependency lint#16571

Merged
epage merged 2 commits intorust-lang:masterfrom
epage:unused
Jan 30, 2026
Merged

feat(lints): Add unused workspace dependency lint#16571
epage merged 2 commits intorust-lang:masterfrom
epage:unused

Conversation

@epage
Copy link
Contributor

@epage epage commented Jan 30, 2026

What does this PR try to resolve?

Fixes #13723

How to test and review this PR?

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@epage epage mentioned this pull request Jan 30, 2026
Merged
@epage epage force-pushed the unused branch 3 times, most recently from 10d608b to 3ed3cef Compare January 30, 2026 19:14
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2026
@weihanglo
refactor: Remove unused workspace dependencies (#16573)
48a7430 
### What does this PR try to resolve?

Found via #16571

### How to test and review this PR?
weihanglo
weihanglo approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@weihanglo weihanglo added this pull request to the merge queue Jan 30, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2026
@epage epage added this pull request to the merge queue Jan 30, 2026
@weihanglo
Copy link
Member

weihanglo commented Jan 30, 2026

Windows GNU x86_64 overflow again. Requeuing.

(I forgot to send this out…)

 thread 'offline::update_offline_cached' (4620) panicked at tests\testsuite\offline.rs:674:26:

test failed running `D:\a\cargo\cargo\target\debug\cargo.exe build`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
    Updating `dummy-registry` index
     Locking 1 package to latest compatible version
    Updating present_dep v1.2.5 -> v1.2.9
 Downloading crates ...
  Downloaded present_dep v1.2.9 (registry `dummy-registry`)
   Compiling present_dep v1.2.9
   Compiling foo v0.1.0 (D:\a\cargo\cargo\target\tmp\cit\t2705\foo)

thread 'main' (7988) has overflowed its stack
error: could not compile `foo` (lib)

Caused by:
  process didn't exit successfully: `rustc --crate-name foo --edition=2015 src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --diagnostic-width=400 --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 --check-cfg cfg(docsrs,test) --check-cfg "cfg(feature, values())" -C metadata=f9346ea166534197 -C extra-filename=-c3ab1f8d9a89b8e6 --out-dir D:\a\cargo\cargo\target\tmp\cit\t2705\foo\target\debug\deps -L dependency=D:\a\cargo\cargo\target\tmp\cit\t2705\foo\target\debug\deps --extern present_dep=D:\a\cargo\cargo\target\tmp\cit\t2705\foo\target\debug\deps\libpresent_dep-e3778c5038798264.rmeta` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)**
  **

Merged via the queue into rust-lang:master with commit fe2f314 Jan 30, 2026
29 checks passed
@epage epage deleted the unused branch January 30, 2026 22:25
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2026
@weihanglo weihanglo mentioned this pull request Jan 31, 2026
Merged
rust-bors bot pushed a commit to rust-lang/rust that referenced this pull request Jan 31, 2026
@bors
Auto merge of #151764 - weihanglo:update-cargo, r=weihanglo
6573c44 
Update cargo submodule

18 commits in efcd9f58636c1990393d495159045d9c35e43b8f..fe2f314aef06e688a9517da1ac0577bb1854d01f
2026-01-23 13:50:59 +0000 to 2026-01-30 21:52:01 +0000
- feat(lints): Add unused workspace dependency lint (rust-lang/cargo#16571)
- docs: Remove redundant homepage link (rust-lang/cargo#16572)
- refactor: Remove unused workspace dependencies (rust-lang/cargo#16573)
- Re-downgrade curl-sys (rust-lang/cargo#16570)
- docs(report): enhance man pages for `cargo report *` (rust-lang/cargo#16430)
- fix(lints): Refine redundant metadata lints (rust-lang/cargo#16564)
- Prevent `cargo init` in home directory (rust-lang/cargo#16566)
- feat(lints): Add redundant_homepage lint  (rust-lang/cargo#16561)
- feat(lints): Add `non_*_case_features` (rust-lang/cargo#16560)
- Update build_std::basic test to ensure index doesn't update (rust-lang/cargo#16559)
- feat(lints): Add mutually exclusive `non_{kebab,snake}_case_packages` (rust-lang/cargo#16554)
- fix(lints): Pluralize non_kebab_case_bins (rust-lang/cargo#16553)
- Add -Z json-target-spec (rust-lang/cargo#16557)
- feat(lint): Add redundant_readme lint  (rust-lang/cargo#16552)
- chore(deps): update msrv (rust-lang/cargo#16387)
- tests: add regression test for --artifact-dir on stable (rust-lang/cargo#16541)
- Don't check the specific build-std output (rust-lang/cargo#16551)
- Fix build-std lto test to run on other platforms (rust-lang/cargo#16550)
rust-bors bot pushed a commit to rust-lang/rust that referenced this pull request Jan 31, 2026
@bors
Auto merge of #151764 - weihanglo:update-cargo, r=weihanglo
310ae8c 
Update cargo submodule

18 commits in efcd9f58636c1990393d495159045d9c35e43b8f..fe2f314aef06e688a9517da1ac0577bb1854d01f
2026-01-23 13:50:59 +0000 to 2026-01-30 21:52:01 +0000
- feat(lints): Add unused workspace dependency lint (rust-lang/cargo#16571)
- docs: Remove redundant homepage link (rust-lang/cargo#16572)
- refactor: Remove unused workspace dependencies (rust-lang/cargo#16573)
- Re-downgrade curl-sys (rust-lang/cargo#16570)
- docs(report): enhance man pages for `cargo report *` (rust-lang/cargo#16430)
- fix(lints): Refine redundant metadata lints (rust-lang/cargo#16564)
- Prevent `cargo init` in home directory (rust-lang/cargo#16566)
- feat(lints): Add redundant_homepage lint  (rust-lang/cargo#16561)
- feat(lints): Add `non_*_case_features` (rust-lang/cargo#16560)
- Update build_std::basic test to ensure index doesn't update (rust-lang/cargo#16559)
- feat(lints): Add mutually exclusive `non_{kebab,snake}_case_packages` (rust-lang/cargo#16554)
- fix(lints): Pluralize non_kebab_case_bins (rust-lang/cargo#16553)
- Add -Z json-target-spec (rust-lang/cargo#16557)
- feat(lint): Add redundant_readme lint  (rust-lang/cargo#16552)
- chore(deps): update msrv (rust-lang/cargo#16387)
- tests: add regression test for --artifact-dir on stable (rust-lang/cargo#16541)
- Don't check the specific build-std output (rust-lang/cargo#16551)
- Fix build-std lto test to run on other platforms (rust-lang/cargo#16550)
@rustbot rustbot added this to the 1.95.0 milestone Jan 31, 2026
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 16, 2026
@bors
Auto merge of #151764 - weihanglo:update-cargo, r=weihanglo
ebb1290 
Update cargo submodule

18 commits in efcd9f58636c1990393d495159045d9c35e43b8f..fe2f314aef06e688a9517da1ac0577bb1854d01f
2026-01-23 13:50:59 +0000 to 2026-01-30 21:52:01 +0000
- feat(lints): Add unused workspace dependency lint (rust-lang/cargo#16571)
- docs: Remove redundant homepage link (rust-lang/cargo#16572)
- refactor: Remove unused workspace dependencies (rust-lang/cargo#16573)
- Re-downgrade curl-sys (rust-lang/cargo#16570)
- docs(report): enhance man pages for `cargo report *` (rust-lang/cargo#16430)
- fix(lints): Refine redundant metadata lints (rust-lang/cargo#16564)
- Prevent `cargo init` in home directory (rust-lang/cargo#16566)
- feat(lints): Add redundant_homepage lint  (rust-lang/cargo#16561)
- feat(lints): Add `non_*_case_features` (rust-lang/cargo#16560)
- Update build_std::basic test to ensure index doesn't update (rust-lang/cargo#16559)
- feat(lints): Add mutually exclusive `non_{kebab,snake}_case_packages` (rust-lang/cargo#16554)
- fix(lints): Pluralize non_kebab_case_bins (rust-lang/cargo#16553)
- Add -Z json-target-spec (rust-lang/cargo#16557)
- feat(lint): Add redundant_readme lint  (rust-lang/cargo#16552)
- chore(deps): update msrv (rust-lang/cargo#16387)
- tests: add regression test for --artifact-dir on stable (rust-lang/cargo#16541)
- Don't check the specific build-std output (rust-lang/cargo#16551)
- Fix build-std lto test to run on other platforms (rust-lang/cargo#16550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels

A-documenting-cargo-itself Area: Cargo's documentation A-workspaces Area: workspaces

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

Add warning for unused workspace dependency

4 participants

@epage @rustbot @weihanglo @ehuss