Skip to content

refactor: Centralize CONTEXT style#16135

Merged
Muscraft merged 1 commit intorust-lang:masterfrom
epage:info
Oct 21, 2025
Merged

refactor: Centralize CONTEXT style#16135
Muscraft merged 1 commit intorust-lang:masterfrom
epage:info

Conversation

@epage
Copy link
Contributor

@epage epage commented Oct 21, 2025

What does this PR try to resolve?

This is similar to #16124 in making it easier for others to see what styles cargo uses and copy them.

How to test and review this PR?

@epage
refactor: Centralize CONTEXT style
93519e5 
This is similar to rust-lang#16124 in making it easier for others to see what
styles cargo uses and copy them.
@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries Command-info S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@weihanglo
Copy link
Member

weihanglo commented Oct 21, 2025 •
edited
Loading

see rust-lang/rust#139070

 ---- package_features::other_member_from_current stdout ----
running `D:\a\cargo\cargo\target\debug\cargo.exe run -p bar --features f1`
running `D:\a\cargo\cargo\target\debug\cargo.exe run -p bar --features f1,f2`
running `D:\a\cargo\cargo\target\debug\cargo.exe run -p bar --features bar/f1`
running `D:\a\cargo\cargo\target\debug\cargo.exe run -p bar --features f1`

thread 'package_features::other_member_from_current' (7188) panicked at tests\testsuite\package_features.rs:362:10:

test failed running `D:\a\cargo\cargo\target\debug\cargo.exe run -p bar --features f1`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
   Compiling bar v0.1.0 (D:\a\cargo\cargo\target\tmp\cit\t2603\foo\bar)

thread 'main' (5588) has overflowed its stack
error: could not compile `bar` (lib)

@weihanglo weihanglo mentioned this pull request Oct 21, 2025
Open
@Muscraft Muscraft added this pull request to the merge queue Oct 21, 2025
Merged via the queue into rust-lang:master with commit 344c456 Oct 21, 2025
44 of 50 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2025
@weihanglo weihanglo mentioned this pull request Oct 22, 2025
Merged
bors added a commit to rust-lang/rust that referenced this pull request Oct 22, 2025
@bors
Auto merge of #147954 - weihanglo:update-cargo, r=weihanglo
0d7813d 
Update cargo submodule

7 commits in 367fd9f213750cd40317803dd0a5a3ce3f0c676d..344c4567c634a25837e3c3476aac08af84cf9203
2025-10-15 15:01:32 +0000 to 2025-10-21 21:29:43 +0000
- refactor: Centralize CONTEXT style (rust-lang/cargo#16135)
- chore(triagebot): `A-json-output` for machine_message.rs (rust-lang/cargo#16133)
- refactor: JSON message with less allocations (rust-lang/cargo#16130)
- More warning conversions (rust-lang/cargo#16126)
- fix(check): Fix suggested command for bin package (rust-lang/cargo#16127)
- fix(script): Remove name sanitiztion outside what is strictly required (rust-lang/cargo#16120)
- refactor: Centralize some more styling (rust-lang/cargo#16124)

r? ghost
@rustbot rustbot added this to the 1.92.0 milestone Oct 22, 2025
@epage epage deleted the info branch November 3, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

@Muscraft Muscraft Muscraft approved these changes

Assignees

@weihanglo weihanglo

Labels

A-interacts-with-crates.io Area: interaction with registries Command-info

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@epage @rustbot @weihanglo @Muscraft