More warning conversions by jneem · Pull Request #16126 · rust-lang/cargo

jneem · 2025-10-16T20:34:47Z

Yet another part of #15944.

I saw some inconsistent formatting for links: some are surrounded in "<>" but others aren't. Is there a policy for that?

rustbot · 2025-10-16T20:34:53Z

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

epage · 2025-10-16T20:39:34Z

I saw some inconsistent formatting for links: some are surrounded in "<>" but others aren't. Is there a policy for that?

rustc dev guide doesn't say anything about it. I'm not away of any extension of ours for how to deal with that.

tests/testsuite/build.rs

epage · 2025-10-16T20:42:23Z

tests/testsuite/collisions.rs

-The targets should have unique names.
-Consider changing their names to be unique or compiling them separately.
-This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.
+[WARNING] output filename collision at [ROOT]/foo/target/debug/deps/{}a{}


Should we move this into an Origin? I think not but unsure

CC @Muscraft

tests/testsuite/collisions.rs

tests/testsuite/doc.rs

tests/testsuite/cargo_alias_config.rs

epage · 2025-10-16T20:47:23Z

tests/testsuite/patch.rs

+[HELP] Check that the patched package version and available features are compatible
+      with the dependency requirements. If the patch has a different version from
+      what is locked in the Cargo.lock file, run `cargo update` to use the new
+      version. This may also occur with an optional dependency that is not enabled.


@Muscraft thoughts on how this should be a formatted?

tests/testsuite/patch.rs

epage

Thanks!

If others have feedback, we can always iterate it on future commits

weihanglo · 2025-10-20T16:35:23Z

@epage

https://www.dockerstatus.com/pages/incident/533c6539221ae15e3f000031/68f65c32245df0465a50b1e0

Docker hub is down due to an AWS us-east-1 outage. I don't think the retry will get through.

weihanglo · 2025-10-20T16:36:25Z

Anyway, let's see.

Update cargo submodule 7 commits in 367fd9f213750cd40317803dd0a5a3ce3f0c676d..344c4567c634a25837e3c3476aac08af84cf9203 2025-10-15 15:01:32 +0000 to 2025-10-21 21:29:43 +0000 - refactor: Centralize CONTEXT style (rust-lang/cargo#16135) - chore(triagebot): `A-json-output` for machine_message.rs (rust-lang/cargo#16133) - refactor: JSON message with less allocations (rust-lang/cargo#16130) - More warning conversions (rust-lang/cargo#16126) - fix(check): Fix suggested command for bin package (rust-lang/cargo#16127) - fix(script): Remove name sanitiztion outside what is strictly required (rust-lang/cargo#16120) - refactor: Centralize some more styling (rust-lang/cargo#16124) r? ghost

rustbot assigned weihanglo Oct 16, 2025