fix: Don't use "did you mean" in errors#15138
Merged
weihanglo merged 5 commits intorust-lang:masterfrom Feb 4, 2025
Merged
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
weihanglo
reviewed
Feb 3, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2025
Update cargo 14 commits in 0e3d73849ab8cbbab3ec5c65cbd555586cb21339..2928e32734b04925ee51e1ae88bea9a83d2fd451 2025-02-01 20:14:40 +0000 to 2025-02-07 16:50:22 +0000 - Simplify backtrack (rust-lang/cargo#15150) - Don't use on Solaris libc::LOCK_* which were removed from libc in ver… (rust-lang/cargo#15143) - feat: emit error if package not found within workspace (rust-lang/cargo#15071) - Make cache tracking resilient to unexpected files (rust-lang/cargo#15147) - Small resolver cleanups (rust-lang/cargo#15040) - feat: add `cargo pkgid` support for cargo-script (rust-lang/cargo#14961) - Suggest similar feature names on CLI (rust-lang/cargo#15133) - fix: Don't use "did you mean" in errors (rust-lang/cargo#15138) - Fix changelog link (rust-lang/cargo#15142) - chore(deps): update rust crate rand to 0.9.0 (rust-lang/cargo#15129) - Remove the original changelog (rust-lang/cargo#15123) - chore(deps): update rust crate gix to 0.70.0 (rust-lang/cargo#15128) - allow windows reserved names in CI (rust-lang/cargo#15135) - removed a word that was repeated (rust-lang/cargo#15136)
joshtriplett
added a commit
to joshtriplett/cargo
that referenced
this pull request
Mar 27, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
joshtriplett
added a commit
to joshtriplett/cargo
that referenced
this pull request
Mar 27, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
epage
pushed a commit
to joshtriplett/cargo
that referenced
this pull request
Sep 12, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
epage
pushed a commit
to joshtriplett/cargo
that referenced
this pull request
Sep 12, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
epage
pushed a commit
to epage/cargo
that referenced
this pull request
Sep 12, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
epage
pushed a commit
to joshtriplett/cargo
that referenced
this pull request
Sep 12, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
epage
pushed a commit
to joshtriplett/cargo
that referenced
this pull request
Sep 12, 2025
Inspired by rust-lang#15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Inspired by #15138 , this eliminates the last three instances. Also rephrase a comment that implied the use of "did you mean" suggestions. Fix an adjacent typo in that comment as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is an attempt at moving Cargo closer to rustc's diagnostic guide (clap already did this)
How should we test and review this PR?
Additional information
I did leave behind three "did you mean"s as I was a little less sure in how to handle them