fixed the error message for a user to open the crate#14969
Merged
epage merged 1 commit intorust-lang:masterfrom Dec 19, 2024
ibilalkayy:doc_crate
Merged
fixed the error message for a user to open the crate#14969epage merged 1 commit intorust-lang:masterfrom ibilalkayy:doc_crate
epage merged 1 commit intorust-lang:masterfrom
ibilalkayy:doc_crate
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Contributor
|
Previously reviewed at #14957 |
epage
approved these changes
Dec 19, 2024
Contributor
|
Thanks! |
Contributor
Author
|
You're welcome, Page! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2024
Update cargo 10 commits in 99dff6d77db779716dda9ca3b29c26addd02c1be..652623b779c88fe44afede28bf7f1c9c07812511 2024-12-18 00:55:17 +0000 to 2024-12-20 15:44:42 +0000 - fix(package): use relpath to cwd for vcs dirtiness report (rust-lang/cargo#14970) - Enable triagebot merge conflict notifications (rust-lang/cargo#14972) - fixed the error message for a user to open the crate (rust-lang/cargo#14969) - fix(package): show dirty filepaths relative to git workdir (rust-lang/cargo#14968) - Add the `test` cfg as a well known cfg before of compiler change (rust-lang/cargo#14963) - refactor(cargo-package): let-else to flatten code (rust-lang/cargo#14959) - fix(cargo-package): add more traces (rust-lang/cargo#14960) - Do not hash absolute sysroot path into stdlib crates metadata. (rust-lang/cargo#14951) - docs: add missing argument to Rustup Cargo workaround (rust-lang/cargo#14954) - fix(cargo-rustc): stabilize higher precedence trailing flags (rust-lang/cargo#14900)
|
Thanks. for future PRs, remember that you can clean commit history and force push in your local branch instead of creating another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR is resolving an issue where
cargo doc --open --examplesdoes not give a clear message when the examples file is given to it.I changed the message from
no crates with documentationin the cargo_doc.rs and doc.rs torequested crate documentation is not available to open. Now it becomes easy for the user to understand what they're missing.Fixes #14776
How should we test and review this PR?
Here is the command through which you can test this change:
cargo test SNAPSHOTS=overwrite -- doc::open_no_doc_crate