fixed the error message for a user to open the crate#14957
Closed
ibilalkayy wants to merge 3 commits intorust-lang:masterfrom
ibilalkayy:crate_doc
Closed
fixed the error message for a user to open the crate#14957ibilalkayy wants to merge 3 commits intorust-lang:masterfrom ibilalkayy:crate_doc
ibilalkayy wants to merge 3 commits intorust-lang:masterfrom
ibilalkayy:crate_doc
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
epage
reviewed
Dec 18, 2024
Member
|
@ibilalkayy The fmt check failed. You need to run |
Contributor
Author
|
Thank you, @Rustin170506! I was not aware of this. Once I get the clarification message from @epage, I will push again. |
Contributor
|
Would you be ok cleaning up the commit history? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR is resolving an issue where
cargo doc --open --examplesdoes not give a clear message when the examples file is given to it.I changed the message from
no crates with documentationin the cargo_doc.rs and doc.rs torequested crate documentation is not available to open. Now it becomes easy for the user to understand what they're missing.Fixes #14776
How should we test and review this PR?
Here is the command through which you can test this change:
cargo test SNAPSHOTS=overwrite -- doc::open_no_doc_crate