docs(ref): Update unstable docs for msrv-policy#13751
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 13, 2024
Merged
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
weihanglo
reviewed
Apr 12, 2024
src/doc/src/reference/unstable.md
Outdated
Comment on lines
+341
to
+342
| Your project's MSRV is determined by taking the lowest `package.rust-version` set in you workspace. | ||
| If there is none set, `rustc -V` will be used to pick up the rust version from rustup's `rust-toolchain.toml`. |
Member
There was a problem hiding this comment.
It might be tricker to explain the rustc invocation when #13659 is merged. rust-toolchain.toml does not always exist either. I might suggest something like:
Suggested change
| Your project's MSRV is determined by taking the lowest `package.rust-version` set in you workspace. | |
| If there is none set, `rustc -V` will be used to pick up the rust version from rustup's `rust-toolchain.toml`. | |
| Your project's MSRV is determined by taking the lowest `package.rust-version` set among all members of your workspace. | |
| If there is none set, the version of rustc Cargo will invoke would be picked as the project's MSRV. |
BTW, what does "project" refer to here? 😆
Contributor
Author
There was a problem hiding this comment.
Went in a slightly different direction.
I also did not write this with an eye for what would go in stable documentation. This is meant to help people in using the unstable feature and I don't think we need to block on this being ideal.
weihanglo
approved these changes
Apr 13, 2024
Member
|
Thanks! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Apr 13, 2024
docs(ref): Update unstable docs for msrv-policy
Member
|
bors is dead? @bors r- |
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Update cargo 11 commits in 48eca1b164695022295ce466b64b44e4e0228b08..6f06fe908a5ee0f415c187f868ea627e82efe07d 2024-04-12 21:16:36 +0000 to 2024-04-16 18:47:44 +0000 - fix(toml): Error on `[project]` in Edition 2024 (rust-lang/cargo#13747) - feat(update): Include a Locking message (rust-lang/cargo#13759) - chore(deps): update rust crate gix to 0.62.0 [security] (rust-lang/cargo#13760) - test(schemas): Ensure tests cover the correct case (rust-lang/cargo#13761) - feat(resolve): Tell the user the style of resovle done (rust-lang/cargo#13754) - Make sure to also wrap the initial `-vV` invocation (rust-lang/cargo#13659) - docs: update `checkout` GitHub action version (rust-lang/cargo#13757) - Recategorize cargo test's `--doc` flag under "Target Selection" (rust-lang/cargo#13756) - Reword sentence describing workspace toml for clarity (rust-lang/cargo#13753) - docs(ref): Update unstable docs for msrv-policy (rust-lang/cargo#13751) - refactor(config): Consistently use kebab-case (rust-lang/cargo#13748) r? ghost
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 17, 2024
Update cargo 11 commits in 48eca1b164695022295ce466b64b44e4e0228b08..6f06fe908a5ee0f415c187f868ea627e82efe07d 2024-04-12 21:16:36 +0000 to 2024-04-16 18:47:44 +0000 - fix(toml): Error on `[project]` in Edition 2024 (rust-lang/cargo#13747) - feat(update): Include a Locking message (rust-lang/cargo#13759) - chore(deps): update rust crate gix to 0.62.0 [security] (rust-lang/cargo#13760) - test(schemas): Ensure tests cover the correct case (rust-lang/cargo#13761) - feat(resolve): Tell the user the style of resovle done (rust-lang/cargo#13754) - Make sure to also wrap the initial `-vV` invocation (rust-lang/cargo#13659) - docs: update `checkout` GitHub action version (rust-lang/cargo#13757) - Recategorize cargo test's `--doc` flag under "Target Selection" (rust-lang/cargo#13756) - Reword sentence describing workspace toml for clarity (rust-lang/cargo#13753) - docs(ref): Update unstable docs for msrv-policy (rust-lang/cargo#13751) - refactor(config): Consistently use kebab-case (rust-lang/cargo#13748) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.