Skip to content

Update cargo#124039

Merged
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo
Apr 17, 2024
Merged

Update cargo#124039
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Apr 16, 2024

11 commits in 48eca1b164695022295ce466b64b44e4e0228b08..6f06fe908a5ee0f415c187f868ea627e82efe07d
2024-04-12 21:16:36 +0000 to 2024-04-16 18:47:44 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Could not assign reviewer from: ghost.
User(s) ghost are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

@weihanglo: no appropriate reviewer found, use r? to override

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@apiraino
Copy link
Contributor

apiraino commented Apr 16, 2024

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Could not assign reviewer from: ghost.
User(s) ghost are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@apiraino
Copy link
Contributor

apiraino commented Apr 16, 2024

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@apiraino
Copy link
Contributor

apiraino commented Apr 16, 2024

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@apiraino
Copy link
Contributor

apiraino commented Apr 16, 2024

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@weihanglo
Copy link
Member Author

weihanglo commented Apr 17, 2024

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Apr 17, 2024

📌 Commit cea6cb3 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
@bors
Copy link
Collaborator

bors commented Apr 17, 2024

⌛ Testing commit cea6cb3 with merge 803e33a...

@bors
Copy link
Collaborator

bors commented Apr 17, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 803e33a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 17, 2024
@bors bors merged commit 803e33a into rust-lang:master Apr 17, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 17, 2024
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 17, 2024

Finished benchmarking commit (803e33a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.3% [-0.3%, -0.3%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 5.9% [5.9%, 5.9%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.3% [-1.3%, 5.9%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.09s -> 678.057s (0.14%)
Artifact size: 316.06 MiB -> 316.15 MiB (0.03%)

@weihanglo weihanglo deleted the update-cargo branch April 17, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weihanglo @rustbot @apiraino @bors @rust-timer