Corrected documentation of how to cache binaries installed with cargo install in CI workflows#11592
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 18, 2023
Merged
Corrected documentation of how to cache binaries installed with cargo install in CI workflows#11592bors merged 1 commit intorust-lang:masterfrom
cargo install in CI workflows#11592bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
weihanglo
approved these changes
Jan 18, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me.
By the way, we prefer a descriptive PR title instead of “fixing issue number X”, for the sake of being friendly when searching old PRs, and also saving one click. It would be better if you could simply update the title.
cargo install in CI workflows
Contributor
Author
Like this? |
Member
|
We don't really strictly follow any rule. A proper title is just right. Thank you! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This was referenced Jan 18, 2023
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2023
3 commits in a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1..50eb688c2bbea5de5a2e8496230a7428798089d1 2023-01-16 18:51:50 +0000 to 2023-01-19 10:09:05 +0000 - Normalize git deps when doing `cargo vendor` for resolving deps inherited from a workspace (rust-lang/cargo#11414) - Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace (rust-lang/cargo#11067) - Corrected documentation of how to cache binaries installed with `cargo install` in CI workflows (rust-lang/cargo#11592)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2023
Update cargo 3 commits in a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1..50eb688c2bbea5de5a2e8496230a7428798089d1 2023-01-16 18:51:50 +0000 to 2023-01-19 10:09:05 +0000 - Normalize git deps when doing `cargo vendor` for resolving deps inherited from a workspace (rust-lang/cargo#11414) - Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace (rust-lang/cargo#11067) - Corrected documentation of how to cache binaries installed with `cargo install` in CI workflows (rust-lang/cargo#11592) r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #11513. Updated the cargo book documentation on how to cache the
$CARGO_HOMEdirectory in CI workflows (added that the.crates.tomland.crates2.jsonfiles must be cached alongside the/binfolder, if installed binaries are cached)