Skip to content

Update cargo#107072

Merged
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo
Jan 20, 2023
Merged

Update cargo#107072
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo

Conversation

@weihanglo
Copy link
Copy Markdown
Member

@weihanglo weihanglo commented Jan 19, 2023

3 commits in a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1..50eb688c2bbea5de5a2e8496230a7428798089d1 2023-01-16 18:51:50 +0000 to 2023-01-19 10:09:05 +0000

r? @ghost

@weihanglo
Update cargo
be02a4a 
3 commits in a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1..50eb688c2bbea5de5a2e8496230a7428798089d1
2023-01-16 18:51:50 +0000 to 2023-01-19 10:09:05 +0000

- Normalize git deps when doing `cargo vendor` for resolving deps inherited from a workspace (rust-lang/cargo#11414)
- Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace (rust-lang/cargo#11067)
- Corrected documentation of how to cache binaries installed with `cargo install` in CI workflows (rust-lang/cargo#11592)
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2023
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 19, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Copy Markdown
Member Author

weihanglo commented Jan 19, 2023

Doing this extra update for Cargo due to we want to ship rust-lang/cargo#11414 in 1.68. The underlying issue has affected a considerable amount of people testing workspace inheritance feature with cargo vendor.

@bors r+ rollup=never p=1

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 19, 2023

📌 Commit be02a4a has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023
@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 19, 2023

⌛ Testing commit be02a4a with merge a2bf475...

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 20, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing a2bf475 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 20, 2023
@bors bors merged commit a2bf475 into rust-lang:master Jan 20, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 20, 2023
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Jan 20, 2023

Finished benchmarking commit (a2bf475): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)		 -2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.9% [-2.1%, -1.8%] 5
Improvements ✅
(secondary)		 -3.0% [-4.2%, -1.7%] 8
All ❌✅ (primary) -1.9% [-2.1%, -1.8%] 5

@weihanglo weihanglo deleted the update-cargo branch January 20, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

4 participants

@weihanglo @rustbot @bors @rust-timer