Add warning when cargo tree -i <spec> can not find packages#11377
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 20, 2022
Merged
Add warning when cargo tree -i <spec> can not find packages#11377bors merged 2 commits intorust-lang:masterfrom
cargo tree -i <spec> can not find packages#11377bors merged 2 commits intorust-lang:masterfrom
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Collaborator
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
weihanglo
reviewed
Nov 15, 2022
Member
weihanglo
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It generally looks great to me!
weihanglo
reviewed
Nov 19, 2022
Member
weihanglo
left a comment
There was a problem hiding this comment.
The rest looks pretty good!
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
c5cc0d9 to
c5eb618
Compare
weihanglo
approved these changes
Nov 20, 2022
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
RalfJung
reviewed
Nov 20, 2022
| ws.config().shell().warn( | ||
| "nothing to print.\n\n\ | ||
| To find dependencies that require specific target platforms, \ | ||
| try use option `--target all` first, and then narrow your search scope accordingly.", |
Member
There was a problem hiding this comment.
I think the grammar is wrong here, should be "try to use" or "try using"
Member
Author
There was a problem hiding this comment.
aha, I'll fix it later. Thanks!
bors
added a commit
that referenced
this pull request
Nov 20, 2022
Fix typo `try use` -> `try to use` See #11377 (comment) r? `@weihanglo`
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Nov 23, 2022
7 commits in eb5d35917b2395194593c9ca70c3778f60c1573b..ba607b23db8398723d659249d9abf5536bc322e5 2022-11-17 22:08:43 +0000 to 2022-11-22 20:52:39 +0000 - Fix failure to parse rustc's JSON output if it is too nested (rust-lang/cargo#11368) - Add suggestions when `cargo add` multiple packages (rust-lang/cargo#11186) - Update mod.rs (rust-lang/cargo#11395) - Fix typo `try use` -> `try to use` (rust-lang/cargo#11394) - Add warning when `cargo tree -i <spec>` can not find packages (rust-lang/cargo#11377) - Clean profile, patch, and replace in cargo remove (rust-lang/cargo#11194) - chore: Upgrade miow (rust-lang/cargo#11391)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2022
Update cargo 7 commits in eb5d35917b2395194593c9ca70c3778f60c1573b..ba607b23db8398723d659249d9abf5536bc322e5 2022-11-17 22:08:43 +0000 to 2022-11-22 20:52:39 +0000 - Fix failure to parse rustc's JSON output if it is too nested (rust-lang/cargo#11368) - Add suggestions when `cargo add` multiple packages (rust-lang/cargo#11186) - Update mod.rs (rust-lang/cargo#11395) - Fix typo `try use` -> `try to use` (rust-lang/cargo#11394) - Add warning when `cargo tree -i <spec>` can not find packages (rust-lang/cargo#11377) - Clean profile, patch, and replace in cargo remove (rust-lang/cargo#11194) - chore: Upgrade miow (rust-lang/cargo#11391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
close #11315
Add warning when
cargo tree -i <spec>can not find packages.How should we test and review this PR?
Please run the unit test.