Skip to content

Add suggestions when cargo add multiple packages#11186

Merged
bors merged 5 commits intorust-lang:masterfrom
0xPoe:rustin-patch-add-suggestion
Nov 22, 2022
Merged

Add suggestions when cargo add multiple packages#11186
bors merged 5 commits intorust-lang:masterfrom
0xPoe:rustin-patch-add-suggestion

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Oct 7, 2022 •
edited
Loading

What does this PR try to resolve?

close #11173
Add suggestions when cargo add multiple packages. See #11173 (comment)

How should we test and review this PR?

  • unit test

@rust-highfive
Copy link

rust-highfive commented Oct 7, 2022

r? @weihanglo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2022
@0xPoe 0xPoe marked this pull request as draft October 7, 2022 10:38
0xPoe
0xPoe commented Oct 7, 2022
View reviewed changes
0xPoe
0xPoe commented Oct 7, 2022
View reviewed changes
@0xPoe
Add suggestions when cargo add multiple packages
6137d25 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe force-pushed the rustin-patch-add-suggestion branch from 613db24 to 6137d25 Compare October 7, 2022 10:53
@0xPoe
Update cargo add test
6ae2921 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe marked this pull request as ready for review October 7, 2022 11:00
epage
epage reviewed Oct 7, 2022
View reviewed changes
@0xPoe 0xPoe requested a review from epage October 8, 2022 02:35
@0xPoe
Copy link
Member Author

0xPoe commented Oct 8, 2022

r? @epage
Thanks for your review! 💚 💙 💜 💛 ❤️

@rust-highfive rust-highfive assigned epage and unassigned weihanglo Oct 8, 2022
pickfire
pickfire reviewed Oct 9, 2022
View reviewed changes
pickfire
pickfire reviewed Oct 9, 2022
View reviewed changes
@0xPoe 0xPoe force-pushed the rustin-patch-add-suggestion branch from a62b1ad to c6274ee Compare October 10, 2022 12:51
@0xPoe 0xPoe requested review from epage and pickfire and removed request for epage and pickfire October 10, 2022 12:56
@0xPoe
Copy link
Member Author

0xPoe commented Oct 10, 2022

image

I guess I encountered a wried bug in GitHub. I just wanna a new review but it will remove one's review at the same time.

epage
epage reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@0xPoe
Rename infer_package to infer_package_for_git_source
6b24d5c 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe force-pushed the rustin-patch-add-suggestion branch from c6274ee to 6b24d5c Compare October 10, 2022 14:19
@0xPoe 0xPoe requested a review from epage October 19, 2022 13:14
pickfire
pickfire approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@0xPoe 0xPoe force-pushed the rustin-patch-add-suggestion branch 2 times, most recently from 2637e08 to 61fe73e Compare November 3, 2022 12:39
@0xPoe 0xPoe force-pushed the rustin-patch-add-suggestion branch from 61fe73e to 6b24d5c Compare November 3, 2022 12:40
@0xPoe
Remove unreachable branches
62bfdf0 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe force-pushed the rustin-patch-add-suggestion branch from 59977d2 to 62bfdf0 Compare November 3, 2022 12:43
@0xPoe
Copy link
Member Author

0xPoe commented Nov 22, 2022

@epage Could you please take another look? Thanks in advance!

epage
epage reviewed Nov 22, 2022
View reviewed changes
@epage
Copy link
Contributor

epage commented Nov 22, 2022

Sorry for the delays, not around a computer as much right now.

@0xPoe
Better expect messages
db3ebb6 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
Copy link
Member Author

0xPoe commented Nov 22, 2022

Sorry for the delays, not around a computer as much right now.

Thanks for your review! 💚 💙 💜 💛 ❤️

@0xPoe 0xPoe requested a review from epage November 22, 2022 10:50
@epage
Copy link
Contributor

epage commented Nov 22, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 22, 2022

📌 Commit db3ebb6 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2022
@bors
Copy link
Contributor

bors commented Nov 22, 2022

⌛ Testing commit db3ebb6 with merge 995f5ef...

@bors
Copy link
Contributor

bors commented Nov 22, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing 995f5ef to master...

@bors bors merged commit 995f5ef into rust-lang:master Nov 22, 2022
weihanglo added a commit to weihanglo/rust that referenced this pull request Nov 23, 2022
@weihanglo
Update cargo
8a808dc 
7 commits in eb5d35917b2395194593c9ca70c3778f60c1573b..ba607b23db8398723d659249d9abf5536bc322e5
2022-11-17 22:08:43 +0000 to 2022-11-22 20:52:39 +0000

- Fix failure to parse rustc's JSON output if it is too nested (rust-lang/cargo#11368)
- Add suggestions when `cargo add` multiple packages (rust-lang/cargo#11186)
- Update mod.rs (rust-lang/cargo#11395)
- Fix typo `try use` -> `try to use` (rust-lang/cargo#11394)
- Add warning when `cargo tree -i <spec>` can not find packages (rust-lang/cargo#11377)
- Clean profile, patch, and replace in cargo remove (rust-lang/cargo#11194)
- chore: Upgrade miow (rust-lang/cargo#11391)
@weihanglo weihanglo mentioned this pull request Nov 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2022
@bors
Auto merge of rust-lang#104752 - weihanglo:update-cargo, r=weihanglo
008bc1d 
Update cargo

7 commits in eb5d35917b2395194593c9ca70c3778f60c1573b..ba607b23db8398723d659249d9abf5536bc322e5 2022-11-17 22:08:43 +0000 to 2022-11-22 20:52:39 +0000

- Fix failure to parse rustc's JSON output if it is too nested (rust-lang/cargo#11368)
- Add suggestions when `cargo add` multiple packages (rust-lang/cargo#11186)
- Update mod.rs (rust-lang/cargo#11395)
- Fix typo `try use` -> `try to use` (rust-lang/cargo#11394)
- Add warning when `cargo tree -i <spec>` can not find packages (rust-lang/cargo#11377)
- Clean profile, patch, and replace in cargo remove (rust-lang/cargo#11194)
- chore: Upgrade miow (rust-lang/cargo#11391)
@ehuss ehuss added this to the 1.67.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epage epage Awaiting requested review from epage

1 more reviewer

@pickfire pickfire pickfire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@epage epage

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

cargo add multiple packages found at no suggestion

7 participants

@0xPoe @rust-highfive @epage @bors @pickfire @ehuss @weihanglo