Semver: Note that it is not a breaking change to make an unsafe function safe#11200
Closed
madsmtm wants to merge 3 commits intorust-lang:masterfrom
Closed
Semver: Note that it is not a breaking change to make an unsafe function safe#11200madsmtm wants to merge 3 commits intorust-lang:masterfrom
unsafe function safe#11200madsmtm wants to merge 3 commits intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
ehuss
reviewed
Oct 9, 2022
Contributor
ehuss
left a comment
There was a problem hiding this comment.
Thanks!
I think at some point in the future, we'll also want to cover unsafe traits/impls.
Contributor
Author
|
Sorry for the delay, I think I've resolved your concerns now. I agree about traits, and also wanted to add a section about |
Contributor
bors
added a commit
that referenced
this pull request
May 9, 2023
Semver: Note that it is not a breaking change to make an unsafe function safe This is a repost of #11200 with some requested edits made. This makes it clear that it is a minor change due to our policy that triggering new lints is not a breaking change. I also simplified it by not repeating what constitutes a breaking change for a trait definition, and instead link to the rule that specifies no signature changes are allowed.
Contributor
|
☔ The latest upstream changes (presumably #12116) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
Closing as merged in #12116. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked this a while ago on the users forum, and thought it would be nice to have in the main documentation.
I marked this as a "minor" change because the only way it breaks is if the user is opting out of Rust's stability guarantees in general. But happy to make it "possibly breaking" if that suits you?