Merged
Conversation
Collaborator
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
epage
reviewed
Jan 18, 2023
epage
reviewed
Jan 18, 2023
weihanglo
approved these changes
Jan 19, 2023
Member
weihanglo
left a comment
There was a problem hiding this comment.
Looks good to me. Just want to check if there is any previous discussion from other Rust teams, specifically clippy team.
epage
reviewed
Jan 19, 2023
Since it is not possible to have "private" features, it can be an issue if users enable it without understanding what it is for.
Contributor
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2023
3 commits in 50eb688c2bbea5de5a2e8496230a7428798089d1..985d561f0bb9b76ec043a2b12511790ec7a2b954 2023-01-19 10:09:05 +0000 to 2023-01-20 14:39:28 +0000 - Stabilize sparse-registry (rust-lang/cargo#11224) - Wrapper type for data that should never be logged (rust-lang/cargo#11545) - Add semver rule for lints (rust-lang/cargo#11596)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2023
Update cargo 3 commits in 50eb688c2bbea5de5a2e8496230a7428798089d1..985d561f0bb9b76ec043a2b12511790ec7a2b954 2023-01-19 10:09:05 +0000 to 2023-01-20 14:39:28 +0000 - Stabilize sparse-registry (rust-lang/cargo#11224) - Wrapper type for data that should never be logged (rust-lang/cargo#11545) - Add semver rule for lints (rust-lang/cargo#11596) r? `@ghost`
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new rule to the semver compatibility list explaining the expectations around diagnostic lints.
cc #8736