This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Support the use of a length field for Range#12
Merged
sophiajt merged 2 commits intorust-dev-tools:masterfrom Apr 27, 2017
skeleten:master
Merged
Support the use of a length field for Range#12sophiajt merged 2 commits intorust-dev-tools:masterfrom skeleten:master
length field for Range#12sophiajt merged 2 commits intorust-dev-tools:masterfrom
skeleten:master
Conversation
This was referenced Apr 27, 2017
nrc
approved these changes
Apr 27, 2017
Contributor
nrc
left a comment
There was a problem hiding this comment.
A couple of minor changes, but otherwise looks good.
|
|
||
| #[derive(Debug, Hash, PartialEq, Eq, PartialOrd, Ord)] | ||
| pub struct Column<I: Indexed>(pub u32, PhantomData<I>); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: please don't remove this blank line
| } | ||
| } | ||
|
|
||
| pub fn new_with_len(row_start: Row<I>, |
Contributor
There was a problem hiding this comment.
we should be consistent about naming - use either len or length for both the field and in the methods.
|
Thanks! |
added 2 commits
April 28, 2017 00:23
The `textDocument/didChange` has an optional `rangeLength` field. This was not previously represented in the `Range` struct, but might be used in `rls_vfs` to handle this event better in case the `end` field is scrambled (looking at you, emacs)
Mainly because I already opened up a PR on rust-lang-nursery/rls that uses a `_len` method :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
textDocument/didChangehas an optionalrangeLengthfield. Thiswas not previously represented in the
Rangestruct, but might be usedin
rls_vfsto handle this event better in case theendfield isscrambled (looking at you, emacs)
related to: rust-lang/rls#281 and rust-dev-tools/rls-vfs#12