Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Set the length field on rls_span::Range#281

Closed
skeleten wants to merge 2 commits intorust-lang:masterfrom
skeleten:master
Closed

Set the length field on rls_span::Range#281
skeleten wants to merge 2 commits intorust-lang:masterfrom
skeleten:master

Conversation

@skeleten
Copy link

@skeleten skeleten commented Apr 27, 2017 •
edited
Loading

This helps rls_vfs with updates, since the end field somtimes does
not contain the valid data (looking at you, emacs)

Fixes #280

related to rust-dev-tools/rls-vfs#12 and rust-dev-tools/rls-span#12

This was referenced Apr 27, 2017
Merged
Merged
Set the length field on rls_span::Range
9e06f0b 
This helps `rls_vfs` with updates, since the `end` field somtimes does
not contain the valid data (looking at you, emacs)
@sophiajt
Copy link

sophiajt commented Apr 28, 2017

Restarting the CI build... I've tried manually bumping the versions the RLS uses, but I'm seeing some issues with not being able to get a successful cargo test.

Can you confirm that cargo test works with this PR? You may need to manually update some of the deps in Cargo.toml

@skeleten
Copy link
Author

skeleten commented Apr 28, 2017

cargo test works for me manuallly. I did however change the racer dependency in rls to refer to "2.0" instead of the git repository, so that rls-vfs and rls use the same version which somehow broke for me

Update dependencies
8cd38f0 
* racer: git -> 2.0
* rls-span: 0.1 -> 0.2
* rls-analysis: git update
* rls-vfs: git update
* rls-data: 0.1 -> 0.3
@skeleten
Copy link
Author

skeleten commented Apr 28, 2017

It seems the test failures are caused by librustc_save_analysis still using the old versions of rls-span and rls-data. Bumping those fixes the test cases.

It seems RLS is peeking into the raw memory of rustc and there were some layout changes made to relevant structures in 0.2 of rls-data, introducing subtle bugs if we use different versions between the two.

This was referenced Apr 28, 2017
Merged
Merged
Merged
@skeleten
Copy link
Author

skeleten commented May 2, 2017

Closing this in favor of #283 being accepted :)

@skeleten skeleten closed this May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skeleten @sophiajt