fix: zero sequence check on relative time#740
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Sep 3, 2024
Merged
Conversation
Member
|
Great catch! I will also copy this commit into #735 so it gets backported to 12.x. |
apoelstra
added a commit
that referenced
this pull request
Nov 27, 2024
9cedc49 bump version to 12.3.0 (Andrew Poelstra) 9420012 fix: zero sequence check on relative time (Chris Hyunhum Cho) 5147c6f descriptor: don't accept strings of the form tr(<key>,) (Andrew Poelstra) 6401c22 miniscript: fix string serialization of and_n (Andrew Poelstra) Pull request description: We are incorrectly serializing and_n as "and_b", and incorrectly parsing `tr(<key>,)`. In master the `and_b` thing is fixed by #722 which rewrites the Display impl completely and the `tr(<key>,)` thing will be fixed as part of a coming series of PRs to clean up expression parsing. Also includes #740 since it showed up in time. ACKs for top commit: sanket1729: ACK 9cedc49 Tree-SHA512: edd45781db5b712e6013a396f6840ce74a6b32861b58a4df25e457c46c845c225dcde95f6c33db7fa314a1c4d2857515f40608d9c66e9432994cadf3d2f10e78
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…elative time
c128e79477a0d7cb27563765b843b3cae97d6311 fix: zero sequence check on relative time (Chris Hyunhum Cho)
Pull request description:
I've just found out RelLockTime misses zero sequence check, which must be disallowed for miniscript.
ACKs for top commit:
apoelstra:
ACK c128e79477a0d7cb27563765b843b3cae97d6311 successfully ran local tests
Tree-SHA512: 9ccc96d67672c2077ec20efeda105e9941a1318030ac63b46e3260b886605d8a7231176413b4dccb6f1542008890f7df977bf4ed445f0fa9550cfa8f8dfaa0e7
apoelstra
added a commit
that referenced
this pull request
Oct 28, 2025
d030b8f feat: add from_height_unchecked (ChrisCho-H) 02a92d8 fix: zero sequence check for from_height (ChrisCho-H) Pull request description: This is following #740. I missed `from_height` also needs to check if zero. I'm afraid as it's API breaking change. ACKs for top commit: apoelstra: ACK d030b8f successfully ran local tests Tree-SHA512: ceac7ece6a61fe485eec7f8e1acccbc1f9ac8a076cbed5c0f6eb83da9a2794d7e8a3fa69d0abf59356ee824d942dcecdfa8a5afba541255bc2e513cc831fa576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just found out RelLockTime misses zero sequence check, which must be disallowed for miniscript.