You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Concept ACK. I'm tempted to also suggest we provide infallible conversions to/from NonZeroU16, but the API for that type is super annoying, and there's also no equivalent type that can express the allowable range of AbsLockTimes so it'd make our API asymmetric.
@ChrisCho-H can you add a from_height_unchecked method which has the original behavior? You don't need to use it anywhere (it's longer to type than from_height(x).unwrap() after all) but I think some users want to grep for unwrap and have the output be clean.
I think NonZeroU16 could be better option for the explicit and infallible usage, but as you mention it would be very inconvenient to use. The only failing case is when zero is given(which is unlikely to happen for the most cases), so we might better not to tighten interface that much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is following #740.
I missed
from_heightalso needs to check if zero.I'm afraid as it's API breaking change.