Fix/error derives 2#559
Merged
apoelstra merged 3 commits intorust-bitcoin:masterfrom May 19, 2021
BP-WG:fix/error-derives-2
Merged
Fix/error derives 2#559apoelstra merged 3 commits intorust-bitcoin:masterfrom BP-WG:fix/error-derives-2
apoelstra merged 3 commits intorust-bitcoin:masterfrom
BP-WG:fix/error-derives-2
Conversation
This was referenced Feb 21, 2021
sanket1729
previously approved these changes
May 4, 2021
Member
sanket1729
left a comment
There was a problem hiding this comment.
utACK b809d83adbc5f9987b2d5d7e34379dfe070e3bee
Collaborator
Author
|
@sanket1729 thank you for your review; unfortunately had to discard it because of rebasing on CI bugfix from #602. Can you pls re-ACK it? |
sgeisler
approved these changes
May 5, 2021
apoelstra
reviewed
May 19, 2021
| InvalidChildNumber(u32), | ||
| /// Error creating a master seed --- for application use | ||
| RngError(String), | ||
| RngError(String), // TODO: This option seems unused and should be removed, opening a way to make this type copiable |
Member
There was a problem hiding this comment.
This is for application use, as mentioned in the doccomment.
apoelstra
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues (and is based on the work from) #558 and is a part of #555 epic for Error types within rust-bitcoin. This PR is also non-API breaking, but unline #558 depends on PRs in upstream repos:
Once they got merged & a new versions of the crates will be published, CI will not be failing anymore here and PR will be ready for reviews