More standard derives for Error#277
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Feb 10, 2021
Merged
Conversation
3 tasks
sgeisler
approved these changes
Jan 30, 2021
apoelstra
approved these changes
Feb 10, 2021
Contributor
Author
|
We need a new minor release in order to unblock rust-bitcoin/rust-bitcoin#559 |
Collaborator
|
Shit, I didn't see this. 😞 I don't think over-promising traits on error types is a good idea. We don't know which variants will come in the future. This is mainly concerning for
Can we remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the discussion in rust-bitcoin/rust-bitcoin#555
This PR is required for further work on error types derives in rust-bitcoin