Fixing hashes core dependency and fuzz feature#602
Fixing hashes core dependency and fuzz feature#602TheBlueMatt merged 1 commit intorust-bitcoin:masterfrom BP-WG:fix/core
Conversation
| default = [ "secp-recovery" ] | ||
| base64 = [ "base64-compat" ] | ||
| fuzztarget = ["bitcoin_hashes/fuzztarget"] | ||
| fuzztarget = [] |
There was a problem hiding this comment.
We should drop this feature entirely now, its been replaced with an explicit --cfg=fuzzing
There was a problem hiding this comment.
Is there any chance that people integrated this recusively into their fuzzing pipeline just as we did with bitcoin_hashes? If so this is a breaking change.
There was a problem hiding this comment.
I would be very surprised if that were the case, though, indeed, its possible. Ultimately its still just in fuzzing pipeline(s), so hopefully not anything that would break any release builds anywhere.
There was a problem hiding this comment.
So I assume we need to leave this as is for 0.26.1 and drop in 0.27?
There was a problem hiding this comment.
If we're not going to yank bitcoin_hashes (which I'm fine with either way) then we can call it a consistent policy. Probably the only thing that will break is rust-Lightning's fuzz crates, and I'm fine dealing with that :).
There was a problem hiding this comment.
Its a little bit confusing that we now have a fuzztarget feature which does nothing at all - you have to set cfg=fuzzing to get any behavior out of it. I think we should drop it.
| default = [ "secp-recovery" ] | ||
| base64 = [ "base64-compat" ] | ||
| fuzztarget = ["bitcoin_hashes/fuzztarget"] | ||
| fuzztarget = [] |
There was a problem hiding this comment.
Is there any chance that people integrated this recusively into their fuzzing pipeline just as we did with bitcoin_hashes? If so this is a breaking change.
|
From what I gather:
I wouldn't be too opposed to just yanking 0.9.5 and 0.9.6 of |
|
Some more research showed that there probably isn't much of a problem as cargo avoids versions with missing features automatically. |
|
I don't care about breaking |
apoelstra
left a comment
There was a problem hiding this comment.
This is fine, even if we don't completely remove the fuzztarget feature.
Caused by the latest
bitcoin_hashesrelease