Rename min_bytes_needed cargo mutants exclude#5119
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Oct 12, 2025
Merged
Rename min_bytes_needed cargo mutants exclude#5119apoelstra merged 1 commit intorust-bitcoin:masterfrom
min_bytes_needed cargo mutants exclude#5119apoelstra merged 1 commit intorust-bitcoin:masterfrom
Conversation
Got missed during rebase, merge, rename, I'd guess. Use the new name when excluding.
Contributor
|
Missing the comment change, and already merged. Done in #5126. |
apoelstra
added a commit
that referenced
this pull request
Oct 13, 2025
80f95b2 Update mutant exclude for lifetime syntax change (Jamil Lambert, PhD) 6133e10 Reword mutant exclude comment (Jamil Lambert, PhD) Pull request description: Two mutant excludes stopped working and caused a timeout in the weekly mutation testing. The lifetimes are now elided to fix a clippy error. And an existing comment needs to be updated in response to a review comment on previous PR. - Fix the comment for a mutant exclude as a follow up to #5094. - Change the excludes to match the new syntax and kill the mutants. Together with #5119 Closes #5121 ACKs for top commit: tcharding: ACK 80f95b2 apoelstra: ACK 80f95b2; successfully ran local tests Tree-SHA512: 547f17a9ab1244467458ce57e2914bd74520401d18c5697812c22921bb078af225e9eaf74f1d3c21efeecfba314d4b9d99fb09994bc573abc8fc36094606144d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got missed during rebase, merge, rename, I'd guess.
Use the new name when excluding.