Skip to content

Update mutant exclude for lifetime syntax change#5126

Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom
jamillambert:1013-mutant-comment
Oct 13, 2025
Merged

Update mutant exclude for lifetime syntax change#5126
apoelstra merged 2 commits intorust-bitcoin:masterfrom
jamillambert:1013-mutant-comment

Conversation

@jamillambert
Copy link
Copy Markdown
Contributor

@jamillambert jamillambert commented Oct 13, 2025

Two mutant excludes stopped working and caused a timeout in the weekly mutation testing. The lifetimes are now elided to fix a clippy error. And an existing comment needs to be updated in response to a review comment on previous PR.

Together with #5119 Closes #5121

Fix the comment for an mutant exclude as a follow up to the PR where it
was added.
Two mutant excludes stopped working and caused a timeout in the weekly
mutation testing. The lifetimes are now elided to fix a clippy error.

Change the excludes to match the new syntax and kill the mutants.
@jamillambert jamillambert changed the title Reword mutant exclude comment Update mutant exclude for lifetime syntax change Oct 13, 2025
Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 80f95b2

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 80f95b2; successfully ran local tests

@apoelstra apoelstra merged commit 56d844d into rust-bitcoin:master Oct 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Mutants Found

3 participants