primitives: Reduce alloc requirements#3711
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Dec 10, 2024
Merged
Conversation
Recently we reduced the `alloc` requirements in `units` but we did not propagate these changes up to `primitives`. Remove a bunch of `alloc` feature gating from `primitives`.
Member
Author
|
hmm I must have botched the API text file stuff, this PR got through CI but https://github.com/rust-bitcoin/rust-bitcoin/actions/runs/12265170371/job/34220646659?pr=3715 has all the stuff that was added here. |
Member
Author
|
Oh, perhaps its because CI ran before #3682 was merged. |
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Dec 10, 2024
In a recent PR (rust-bitcoin#3682) we introduced api text files. Then in another PR (rust-bitcoin#3711) we removed `alloc` feature gating. Possibly due to the timing of running through CI and merging these two PRs managed to get merged without an update to the API text files. As would be expected; removing the `alloc` feature gate adds a bunch of new lines to the `no-features` api text file.
Member
Author
|
#3721 adds the api text file changes introduced by this PR. |
apoelstra
added a commit
that referenced
this pull request
Dec 12, 2024
601a47f Add new api text file changes (Tobin C. Harding) Pull request description: In a recent PR (#3682) we introduced api text files. Then in another PR (#3711) we removed `alloc` feature gating. Possibly due to the timing of running through CI and merging these two PRs managed to get merged without an update to the API text files. As would be expected; removing the `alloc` feature gate adds a bunch of new lines to the `no-features` api text file. ACKs for top commit: jamillambert: ACK 601a47f apoelstra: ACK 601a47f; successfully ran local tests Tree-SHA512: 65e22192bcc386172ec1b74651c35deef954f9f461e6dc0758140b67c62c9afa0290031ddb04d67455a558dbfb10126c042c01002057b400cd5aff7d4e38e4da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we reduced the
allocrequirements inunitsbut we did not propagate these changes up toprimitives.Remove a bunch of
allocfeature gating fromprimitives.