Add new api text file changes#3721
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Dec 12, 2024
Merged
Conversation
In a recent PR (rust-bitcoin#3682) we introduced api text files. Then in another PR (rust-bitcoin#3711) we removed `alloc` feature gating. Possibly due to the timing of running through CI and merging these two PRs managed to get merged without an update to the API text files. As would be expected; removing the `alloc` feature gate adds a bunch of new lines to the `no-features` api text file.
5ced144 to
601a47f
Compare
This was referenced Dec 10, 2024
Merged
Member
Author
|
bump @apoelstra can you prioritise this one please, its blocking all other open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent PR (#3682) we introduced api text files. Then in another PR (#3711) we removed
allocfeature gating. Possibly due to the timing of running through CI and merging these two PRs managed to get merged without an update to the API text files.As would be expected; removing the
allocfeature gate adds a bunch of new lines to theno-featuresapi text file.