Rename Script::empty to Script::new#1925
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jul 18, 2023
Merged
Conversation
2d60c82 to
36d072e
Compare
Contributor
|
SGTM |
apoelstra
approved these changes
Jun 28, 2023
Member
apoelstra
left a comment
There was a problem hiding this comment.
ACK 36d072eadc0e7efb19c4bc53613e3ffe1528045e
The `empty` constructor is mis-named for the following reasons: - Non-uniform with `ScriptBuf::new` - Non-standard with respect to stdlib which uses `Path::new` and `PathBuf::new` (on which we based the `Scritp`/`ScriptBuf`) Rename the function to `new`, put it at the top of the impl block while we are at it.
Member
Author
|
Rebased on master (to pick up #1927). No other changes. |
36d072e to
9787ba6
Compare
apoelstra
approved these changes
Jul 8, 2023
RCasatta
approved these changes
Jul 18, 2023
apoelstra
added a commit
that referenced
this pull request
Aug 1, 2023
55be538 policy: Add refactor carve out (Tobin C. Harding) Pull request description: I have managed to burn out or bore our reviewers/maintainers. Getting two acks is becoming increasingly difficult. I've pestered everyone to the limit that I feel socially comfortable doing so, and as such, am requesting a carve out to the 2-ACK before merge rule. The primary justification is that I feel we should have a bit more of BDFL and a bit less total consensus if we are to push forwards. ### Example PRs where this change would apply - #1925 - #1854 - #1862 ACKs for top commit: elichai: I agree this makes sense for refactors ACK 55be538 apoelstra: ACK 55be538 sanket1729: ACK 55be538. Same reasons as apoelstra. And this is only for re-factors that are not adding any new features. RCasatta: ACK 55be538 Tree-SHA512: a5e206252015f49245ed282a3be7a35760d16f94dc6e60f31edf589a41ef642eba52a3bd7d1375b6033f3cf0128f47beee4f03e59cad151c64eedd71ac98baac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
emptyconstructor is mis-named for the following reasons:ScriptBuf::newPath::newandPathBuf::new(on which we based theScritp/ScriptBuf)Rename the function to
new, put it at the top of the impl block while we are at it.