Skip to content

update proc-macro to 1.0.56 to 1.0.63#1927

Merged
apoelstra merged 1 commit intomasterfrom
2023-06--fix-nightly
Jul 7, 2023
Merged

update proc-macro to 1.0.56 to 1.0.63#1927
apoelstra merged 1 commit intomasterfrom
2023-06--fix-nightly

Conversation

@apoelstra
Copy link
Copy Markdown
Member

1.0.56 does not compile on Rust nightly anymore.

1.0.56 does not compile on Rust nightly anymore.
Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider only using the recent lock file for nightly tests for similar but opposite reasons to why I made MSRV only use minimal one i.e., if does not make a lot of sense to use a nightly toolchain with really old dependencies.

ce21bf2

But ACK c958112

@apoelstra
Copy link
Copy Markdown
Member Author

The dependencies in the lockfile are supposed to reflect ones that we've vetted. I don't think we should change that just because the Rust compiler sometimes has breaking changes.

@yancyribbens
Copy link
Copy Markdown
Contributor

ACK c958112

tested locally also by overwriting Cargo.lock with Cargo-minimal.lock and building nightly

Copy link
Copy Markdown

@adoerr adoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c958112

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c958112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants