Skip to content

Run cargo +nightly rustfmt#1728

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:03-22-rustfmt
Mar 22, 2023
Merged

Run cargo +nightly rustfmt#1728
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:03-22-rustfmt

Conversation

@tcharding
Copy link
Copy Markdown
Member

We just merged a patch to enable formatting in CI but commit: 05fdead2 Feature: Add difficulty_float method for block::Header. must have slipped in.

Run the formatter.

We just merged a patch to enable formatting in CI but commit: `05fdead2
Feature: Add difficulty_float method for block::Header.` must have
slipped in.

Run the formatter.
This was referenced Mar 22, 2023
Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5781896

@Kixunil Kixunil added the P-high High priority label Mar 22, 2023
@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Mar 22, 2023

Setting P-high since IIUC this blocks CI.

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5781896

@apoelstra apoelstra merged commit 0f98c56 into rust-bitcoin:master Mar 22, 2023
@tcharding tcharding deleted the 03-22-rustfmt branch March 22, 2023 21:03
apoelstra added a commit that referenced this pull request Mar 23, 2023
1dc04fe Remove rust_v_1_46 (Tobin C. Harding)
71fa9e8 Bump MSRV to 1.48.1 (Tobin C. Harding)

Pull request description:

  Just patch 2, patch 1 is #1728

  From the commit log of patch 2

      Bump MSRV to 1.48.1

      As per discussion [0] bump our MSRV for all crates in `rust-bitcoin`
      repo to 1.48.1 [1].

      [0] #1329
      [1] https://blog.rust-lang.org/2020/11/19/Rust-1.48.html

ACKs for top commit:
  apoelstra:
    ACK 1dc04fe
  sanket1729:
    ACK 1dc04fe

Tree-SHA512: 533470c55f7aeede88382db8245033dac9317d75b38ced2ad8256d38319632a524335f893044e96300a1e60048f9aaca2d1634735eb324eb8ed9ad3c9ab2f872
apoelstra added a commit that referenced this pull request Mar 23, 2023
122188f Use shorter import statements (Tobin C. Harding)

Pull request description:

  Just patch 2, patch 1 is #1728

  From the commit log of patch 2

      Use shorter import statements

      As per discussion [0] use the shorter form for importing crates that we
      re-export (`hashes` and `secp256k1`).

      [0] #1661

ACKs for top commit:
  apoelstra:
    ACK 122188f
  sanket1729:
    utACK 122188f

Tree-SHA512: 3f540464d38c72ba9d68f8ceda8600540bd0c3eef0ba67531c87fa1e0e4f757af7035cf80a1a5f17aa05604a17fdd9ef59bb6bece6b4145d540dac1e5362fc01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-high High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants