Conversation
|
Concept ACK, will wait for rebase. I'd like to take look into actually making use of this changes. |
|
Also if you're rebasing anyway, you could remove 46 from |
Please clarify, does that mean:
Damn written language, why don't we speak in 0s and 1s |
As per discussion [0] bump our MSRV for all crates in `rust-bitcoin` repo to 1.48.1 [1]. [0] rust-bitcoin#1329 [1] https://blog.rust-lang.org/2020/11/19/Rust-1.48.html
We just bumped the MSRV to 1.48.0 so we know that we have all features from 1.46, no need for `rust_v_1_46` check anymore.
|
Rebased on master and removed |
|
@tcharding if you know what to look for feel free to do it yourself, I kinda felt like I was the only one who had an idea because of my enthusiasm. :) There are already some things tracked in #1060 but I was thinking more about arrays/const generics - we should be able to add But I think I did see some other places that would be less annoying now, don't remember where. Also note that neither |
|
No worries, I don't know what to look for but its a good chance for me to read the release notes of Rust 1.41 -> 1.48 and try to learn. Won't be the last time we bump MSRV. I definitely won't claim to find everything that can be improved. |
Just patch 2, patch 1 is #1728
From the commit log of patch 2