Skip to content

Bump MSRV to 1.48.0#1729

Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom
tcharding:03-22-msrv
Mar 23, 2023
Merged

Bump MSRV to 1.48.0#1729
apoelstra merged 2 commits intorust-bitcoin:masterfrom
tcharding:03-22-msrv

Conversation

@tcharding
Copy link
Copy Markdown
Member

Just patch 2, patch 1 is #1728

From the commit log of patch 2

Bump MSRV to 1.48.1

As per discussion [0] bump our MSRV for all crates in `rust-bitcoin`
repo to 1.48.1 [1].

[0] https://github.com/rust-bitcoin/rust-bitcoin/discussions/1329
[1] https://blog.rust-lang.org/2020/11/19/Rust-1.48.html

@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Mar 22, 2023

Concept ACK, will wait for rebase. I'd like to take look into actually making use of this changes.

@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Mar 22, 2023

Also if you're rebasing anyway, you could remove 46 from build.rs and the associated feature gates.

@apoelstra apoelstra mentioned this pull request Mar 22, 2023
@tcharding
Copy link
Copy Markdown
Member Author

I'd like to take look into actually making use of this changes.

Please clarify, does that mean:

  1. you'd like me to add changes to this PR using the new MSRV?
  2. you'd like to investigate yourself using the new MSRV before deciding if we should merge this?
  3. something else?

Damn written language, why don't we speak in 0s and 1s

As per discussion [0] bump our MSRV for all crates in `rust-bitcoin`
repo to 1.48.1 [1].

[0] rust-bitcoin#1329
[1] https://blog.rust-lang.org/2020/11/19/Rust-1.48.html
We just bumped the MSRV to 1.48.0 so we know that we have all features
from 1.46, no need for `rust_v_1_46` check anymore.
@tcharding
Copy link
Copy Markdown
Member Author

Rebased on master and removed rust_1_46.

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1dc04fe

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1dc04fe

@apoelstra apoelstra merged commit 3417585 into rust-bitcoin:master Mar 23, 2023
@tcharding tcharding deleted the 03-22-msrv branch March 23, 2023 04:20
@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Mar 23, 2023

@tcharding if you know what to look for feel free to do it yourself, I kinda felt like I was the only one who had an idea because of my enthusiasm. :) There are already some things tracked in #1060 but I was thinking more about arrays/const generics - we should be able to add AsRef<[u8]> + AsMut<[u8]> + Borrow<[u8]> + BorrowMut<[u8]> bound to Hash::Bytes, also where &[u8]: TryInto<Self::Bytes, Error=core::array::TryFromSliceError>.

But I think I did see some other places that would be less annoying now, don't remember where. Also note that neither hex nor PushSlice can use it since they require specific lengths.

@tcharding
Copy link
Copy Markdown
Member Author

No worries, I don't know what to look for but its a good chance for me to read the release notes of Rust 1.41 -> 1.48 and try to learn. Won't be the last time we bump MSRV. I definitely won't claim to find everything that can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants