Skip to content

Swap out Work::log2 implementation for U256::to_f64#1713

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
junderw:junderw/swap-work-log2
Mar 18, 2023
Merged

Swap out Work::log2 implementation for U256::to_f64#1713
apoelstra merged 1 commit intorust-bitcoin:masterfrom
junderw:junderw/swap-work-log2

Conversation

@junderw
Copy link
Copy Markdown
Contributor

@junderw junderw commented Mar 17, 2023

@junderw junderw force-pushed the junderw/swap-work-log2 branch from 44a5413 to 4924148 Compare March 17, 2023 21:10
Kixunil
Kixunil approved these changes Mar 18, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4924148

@Kixunil Kixunil added trivial Obvious, easy and quick to review (few lines or doc-only...) one ack PRs that have one ACK, so one more can progress them labels Mar 18, 2023
@Kixunil Kixunil mentioned this pull request Mar 18, 2023
Merged
8 tasks
apoelstra
apoelstra approved these changes Mar 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4924148

@apoelstra apoelstra merged commit 35cff6a into rust-bitcoin:master Mar 18, 2023
apoelstra added a commit that referenced this pull request Mar 22, 2023
@apoelstra
Merge #1699: Release tracking PR - v0.30.0
d65646c 
ffee8ad Bump version to v0.30.0 (Tobin C. Harding)

Pull request description:

  Add changelog notes and bump the version number to v0.30.0.

  ## TODO - pre-merge

  - [x] Release `bitcoin_hashes` 0.12: #1694
  - [x] Release secp 0.27: rust-bitcoin/rust-secp256k1#588
    - rust-bitcoin/rust-secp256k1#590
  - [x] Update `secp256k1` dependency to use newly released v0.27: #1714
  - [x] Merge
    - ~#1696
    - #1695
    -  #1111
  - [x] If time permits merge these:
    - #1710
    - #1705
    - #1713
  - [x] Set the release date in changelog header
  - [x] And merge these:
    - #1721
    - #1720
    - #1719
    - #1717

  ## TODO  - post release
  - [ ] Release the blogpost: rust-bitcoin/www.rust-bitcoin.org#2
     - ~Set the date in the blog post to match the date 0.30 is released~

ACKs for top commit:
  sanket1729:
    reACK ffee8ad
  Kixunil:
    ACK ffee8ad
  apoelstra:
    ACK ffee8ad

Tree-SHA512: b0ea113ee1726fd9b263d0e01fe14bd544c007c05a9ac43b6c2d4edbeef3bb3ad456b061ef086626e1e1b27a0cda49cb6bc28aac3ad1691d72ffe00400ed5b45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees

No one assigned

Labels

one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@junderw @Kixunil @apoelstra