Conversation
Because we have rust-secp in the loop, we need to update rust-secp, push a new tag, and use that here, to ensure that the direct dependency on bitcoin_hashes, and the rust-secp version, are compatible.
|
I'm in favour of releasing |
Mad leetspeak :) |
|
@Kixunil I'll go ahead and fix it today, but I think it can wait for a point release if we get two acks on it. This PR is blocking other releases, while fixing schemars won't. |
sanket1729
left a comment
There was a problem hiding this comment.
utACK bfd401c. ChangeLog looks good to me, did not review whether all noteworthy changes were included.
|
Will wait for us to decide on #1696 before merging. |
|
I can't get #1696 today. Can we merge without it or else someone pick it up for me please? |
|
Yeah, let's do it. I just learned today that releasing before 9 March would be really, really nice for me. :) |
|
Yay! |
|
Lol, dammit. We actually have to release |
|
Hey @apoelstra, we tagged with Perhaps this commit: |
|
Oops, I did label the same commit |
ffee8ad Bump version to v0.30.0 (Tobin C. Harding) Pull request description: Add changelog notes and bump the version number to v0.30.0. ## TODO - pre-merge - [x] Release `bitcoin_hashes` 0.12: #1694 - [x] Release secp 0.27: rust-bitcoin/rust-secp256k1#588 - rust-bitcoin/rust-secp256k1#590 - [x] Update `secp256k1` dependency to use newly released v0.27: #1714 - [x] Merge - ~#1696 - #1695 - #1111 - [x] If time permits merge these: - #1710 - #1705 - #1713 - [x] Set the release date in changelog header - [x] And merge these: - #1721 - #1720 - #1719 - #1717 ## TODO - post release - [ ] Release the blogpost: rust-bitcoin/www.rust-bitcoin.org#2 - ~Set the date in the blog post to match the date 0.30 is released~ ACKs for top commit: sanket1729: reACK ffee8ad Kixunil: ACK ffee8ad apoelstra: ACK ffee8ad Tree-SHA512: b0ea113ee1726fd9b263d0e01fe14bd544c007c05a9ac43b6c2d4edbeef3bb3ad456b061ef086626e1e1b27a0cda49cb6bc28aac3ad1691d72ffe00400ed5b45
It was a little tricky to bump the version number because of #1553. There are a couple other things I considered trying, which maybe we'll do for future releases, but I believe this works for now.
Maybe should wait for #1111.