-
Notifications
You must be signed in to change notification settings - Fork 966
[epic] Tracking issue for bitcoin_num adoption #467
Copy link
Copy link
Closed
Description
Action points
These points have to be completed step by step:
- Create bitcoin_num crate transferring all hex, endian and number-related helper macro functions from both bitcoin_hashes and rust-bitcoin http://github.com/LNP-BP/bitcoin_num/
- Publish bitcoin_num to crates.io https://crates.io/crates/bitcoin_num
- Create a PR adopting bitcoin_num for bitcoin_hashes Moving hex and endian functionality to bitcoin_num crate bitcoin_hashes#91
- Move bitcoin_num to rust-bitcoin GitHub org
- (optionally) add @dr-orlovsky to rust-bitcoin GitHub org as a member
- Review & merge Original code from bitcoin and bitcoin_hashes crates BP-WG/bitcoin_num#1
- Review & merge Finalizing set of endian-related functions BP-WG/bitcoin_num#2
- Review & merge Formatting code with cargo fmt BP-WG/bitcoin_num#3
- Review & merge Changes required to use crate in bitcoin_hashes BP-WG/bitcoin_num#4
- Review & accept PR adopting bitcoin_num for bitcoin_hashes
- Create a PR adopting bitcoin_num for rust-bitcoin
- Review & accept PR adopting bitcoin_num for rust-bitcoin
- Bump and publish new bitcoin_hashes version
- Bump and publish new rust-bitcoin version
PS. Here is copy of the original issue opening post:
It seems util::endian https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/endian.rs is is just a copy-paste from https://github.com/rust-bitcoin/bitcoin_hashes/blob/master/src/util.rs#L149-L210
Is there any specific reason of doing that or just a mistake? Why not to export functions from bitcoin_hashes and import them at rust-bitcoin?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels