This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Moving hex and endian functionality to bitcoin_num crate#91
Closed
dr-orlovsky wants to merge 1 commit intorust-bitcoin:masterfrom
Closed
Moving hex and endian functionality to bitcoin_num crate#91dr-orlovsky wants to merge 1 commit intorust-bitcoin:masterfrom
dr-orlovsky wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
14 tasks
Contributor
Author
|
Closing as heavily outdated and not agreed with overall multi-crate split strategy discussed last year. More details: rust-bitcoin/rust-bitcoin#467 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements rust-bitcoin/rust-bitcoin#467
Since rust denies typed foreign traint implementation (like
impl<T: Hash> FromHex for T) I had to introduce new traitInnerHexinbitcoin_numcrate and make a trick with it (see the code changes). I think this overall improves type system and future extensibility.UPD: All moved hex and util functions are still re-exported by bitcoin_hashes with the same mod name and paths, for compatibility purposes and for reducing amount of changes that needs to be introduced into bitcoin_hashes code.