This repository was archived by the owner on Jan 10, 2022. It is now read-only.
Changes required to use crate in bitcoin_hashes#4
Closed
dr-orlovsky wants to merge 17 commits intomasterfrom
Closed
Changes required to use crate in bitcoin_hashes#4dr-orlovsky wants to merge 17 commits intomasterfrom
dr-orlovsky wants to merge 17 commits intomasterfrom
Conversation
…macros taken from rust-bitcoin
14 tasks
stevenroose
reviewed
Oct 8, 2020
| use hex; | ||
| use std::error; | ||
|
|
||
| impl error::Error for hex::Error { |
There was a problem hiding this comment.
Is this allowed? I thought an impl had to be in the same module as either the type or the trait? Is it same crate instead of same module?
Member
Author
There was a problem hiding this comment.
hex::Error is defined in this module and you can impl foreign traits for locally-defined types. So yes, this works and compile.
e6390cb to
7ae7d01
Compare
7ae7d01 to
6243bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.