Skip to content

units: Remove internals::InputString from the public API  #3708

@tcharding

Description

@tcharding

internals is not stable and is not going to be. Nothing from internals should appear in the public API of any of the leaf crates.

Fail

core::convert::Into<bitcoin_internals::error::input_string::InputString>>(s: S) -> core::result::Result<T, bitcoin_units::parse::ParseIntError>

Also the parse::int function

pub fn int<T: Integer, S: AsRef<str> + Into<InputString>>(s: S) -> Result<T, ParseIntError> {

As a rule so this doesn't happen again I don't think we should put types into internals - period.

This issue will likely be solved as part of #3732

Metadata

Metadata

Assignees

No one assigned

    Labels

    1.0Issues and PRs required or helping to stabilize the APIC-unitsPRs modifying the units crate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions