units: Remove InputString from the public API#3905
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Jan 15, 2025
Merged
units: Remove InputString from the public API#3905apoelstra merged 2 commits intorust-bitcoin:masterfrom
InputString from the public API#3905apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
Currently `InputString` is in the public API of `units` because of the trait bound on `parse::int()`. We can just do the monomorphisisation manually to remove it. This patch renames `int` to have three different names, one for `&str` one for `String`, and one for `Box<str>`.
Member
Author
|
This is #3848 re-opened because I accidentally closed it. |
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
InputStringis in the public API ofunitsbecause of the trait bound onparse::int(). We can just do the monomorphisisation manually to remove it.This patch renames
intto have three different names, one for&strone forString, and one forBox<str>e.g.,units::parse::int_from_str.Close #3708