Check that BASERUBY is at least Ruby 2.2 in configure#2947
Merged
Conversation
Member
|
Indents in vcs.rb seem corrupted? |
Contributor
Author
|
@nobu You are right, sorry about that. I'll fix it and push a fixed commit. |
1328827 to
9c321dd
Compare
nurse
pushed a commit
to nurse/ruby
that referenced
this pull request
Mar 13, 2020
* Fix gem pristine not accounting for user installed gems. Pull request
ruby#2914 by Luis Sagastume.
* Refactor keyword argument test for Ruby 2.7. Pull request ruby#2947 by
SHIBATA Hiroshi.
* Fix errors at frozen Gem::Version. Pull request ruby#2949 by Nobuyoshi
Nakada.
* Remove taint usage on Ruby 2.7+. Pull request ruby#2951 by Jeremy Evans.
* Check Manifest.txt is up to date. Pull request ruby#2953 by David Rodríguez.
* Clarify symlink conditionals in tests. Pull request ruby#2962 by David
Rodríguez.
* Update command line parsing to work under ps. Pull request ruby#2966 by
David Rodríguez.
* Properly test `Gem::Specifications.stub_for`. Pull request ruby#2970 by
David Rodríguez.
* Fix Gem::LOADED_SPECS_MUTEX handling for recursive locking. Pull request
ruby#2985 by MSP-Greg.
BASERUBY needs to be at least Ruby 2.2 since 46acd00. I think it's better to explicitly fail early as soon as BASERUBY is used in this case, versus trying to debug later failures. This modifies things to check both implicitly use of ruby in the PATH as BASERUBY, and explicitly specified older versions of ruby when using --with-baseruby. Fixes [Bug ruby#16668]
BASERUBY now requires at least Ruby 2.2, so there is no point trying to support older ruby versions here.
9c321dd to
053e788
Compare
Member
|
If nobu says OK, you can merge this. |
nobu
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BASERUBY needs to be at least Ruby 2.2 since
46acd00.
I think it's better to explicitly fail early as soon as BASERUBY
is used in this case, versus trying to debug later failures.
This modifies things to check both implicitly use of ruby in the
PATH as BASERUBY, and explicitly specified older versions of ruby
when using --with-baseruby.
Additionally, since all supported BASERUBY versions support
--disable=gems, always specify that instead of checking for
support.
Remove Ruby <2.2 support from tool/lib/vcs.rb
BASERUBY now requires at least Ruby 2.2, so there is no point
trying to support older ruby versions here.
This should address [Bug #16668]