Skip to content

support multi-run test for test_readline.rb#2914

Merged
aycabta merged 1 commit into
ruby:masterfrom
S-H-GAMELINKS:fix_test_readline_for_multirun
Feb 19, 2020
Merged

support multi-run test for test_readline.rb#2914
aycabta merged 1 commit into
ruby:masterfrom
S-H-GAMELINKS:fix_test_readline_for_multirun

Conversation

@S-H-GAMELINKS

Copy link
Copy Markdown
Contributor

Somtimes make test-all TESTS="--repeat-count="50"" is Fail.

TestReadline#test_line_buffer__point [/home/ubuntu/environment/workdir/ruby/test/readline/test_readline.rb:101]:
<"second"> expected but was
<" second">.
[15857/19977] TestReadline#test_using_quoting_detection_proc_with_multibyte_input = 0.00 s
  2) Failure:
TestReadline#test_using_quoting_detection_proc_with_multibyte_input [/home/ubuntu/environment/workdir/ruby/test/readline/test_readline.rb:586]:
<"あん completion"> expected but was
<"あん completion ">.

TestReadline#test_line_buffer__point is failed by TestReadline#test_some_characters_methods(throw Exception). And Readline.special_prefixes is .

TestReadline#test_line_buffer__point [/home/ubuntu/environment/workdir/ruby/test/readline/test_readline.rb:101]:
<"second"> expected but was
<" second">.

TestReadline#test_using_quoting_detection_proc_with_multibyte_input is failed to ReadlineReadline.completion_append_character is .

So, there's re-init in teardown.

@aycabta aycabta merged commit 5fd5666 into ruby:master Feb 19, 2020
@aycabta

aycabta commented Feb 19, 2020

Copy link
Copy Markdown
Member

Good catch! Thank you so much!

@S-H-GAMELINKS S-H-GAMELINKS deleted the fix_test_readline_for_multirun branch February 21, 2020 07:29
nurse pushed a commit to nurse/ruby that referenced this pull request Mar 13, 2020
  * Fix gem pristine not accounting for user installed gems. Pull request
    ruby#2914 by Luis Sagastume.
  * Refactor keyword argument test for Ruby 2.7. Pull request ruby#2947 by
    SHIBATA Hiroshi.
  * Fix errors at frozen Gem::Version. Pull request ruby#2949 by Nobuyoshi
    Nakada.
  * Remove taint usage on Ruby 2.7+. Pull request ruby#2951 by Jeremy Evans.
  * Check Manifest.txt is up to date. Pull request ruby#2953 by David Rodríguez.
  * Clarify symlink conditionals in tests. Pull request ruby#2962 by David
    Rodríguez.
  * Update command line parsing to work under ps. Pull request ruby#2966 by
    David Rodríguez.
  * Properly test `Gem::Specifications.stub_for`. Pull request ruby#2970 by
    David Rodríguez.
  * Fix Gem::LOADED_SPECS_MUTEX handling for recursive locking. Pull request
    ruby#2985 by MSP-Greg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants