fix: rrweb recorder may throw error when stopping recording after an iframe becomes cross-origin by YunFeng0817 · Pull Request #1695 · rrweb-io/rrweb

YunFeng0817 · 2025-05-27T21:07:16Z

The CI failure can be solved by #1696

…iframe becomes cross-origin

changeset-bot · 2025-05-27T21:07:21Z

🦋 Changeset detected

Latest commit: b88b3fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages

Name	Type
rrweb	Patch
rrweb-snapshot	Patch
rrdom	Patch
rrdom-nodejs	Patch
rrweb-player	Patch
@rrweb/all	Patch
@rrweb/replay	Patch
@rrweb/record	Patch
@rrweb/types	Patch
@rrweb/packer	Patch
@rrweb/utils	Patch
@rrweb/web-extension	Patch
rrvideo	Patch
@rrweb/rrweb-plugin-console-record	Patch
@rrweb/rrweb-plugin-console-replay	Patch
@rrweb/rrweb-plugin-sequential-id-record	Patch
@rrweb/rrweb-plugin-sequential-id-replay	Patch
@rrweb/rrweb-plugin-canvas-webrtc-record	Patch
@rrweb/rrweb-plugin-canvas-webrtc-replay	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull Request Overview

This PR fixes an issue where the rrweb recorder throws an error when stopping recording after an iframe becomes cross-origin. The changes wrap the stop handlers in a try/catch block to suppress expected cross-origin errors and a new test case has been added to validate the fix.

Wraps each handler call in a try/catch to prevent cross-origin access errors.
Adds a new test to verify that stopping the recorder after setting an iframe’s src to a cross-origin URL does not throw an error.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/rrweb/test/record.test.ts	Adds a test ensuring that stopping recording after an iframe becomes cross-origin does not throw an error.
packages/rrweb/src/record/index.ts	Wraps handler calls in a try/catch to safely ignore expected cross-origin errors.

Comments suppressed due to low confidence (1)

packages/rrweb/test/record.test.ts:1002

[nitpick] Consider using a more robust waiting mechanism such as an event listener or polling for a condition instead of a fixed timeout to avoid potential flakiness in tests.

await new Promise((resolve) => setTimeout(resolve, 1000));

packages/rrweb/src/record/index.ts

Copilot

Pull Request Overview

This PR prevents errors when stopping the rrweb recorder after an iframe changes to cross-origin, adds a test for this scenario, and bumps the patch version.

Add a functional test to verify no exception is thrown when stopping recording post cross-origin iframe navigation.
Wrap each stop-record handler in try/catch and ignore known cross-origin access errors.
Update the changeset to publish a patch release.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/rrweb/test/record.test.ts	Added test ensuring stopRecord doesn’t throw after iframe src changes to cross-origin
packages/rrweb/src/record/index.ts	Wrapped cleanup handlers in try/catch and suppress cross-origin frame errors
.changeset/nervous-actors-jam.md	Bumped patch version with PR description

packages/rrweb/test/record.test.ts

packages/rrweb/src/record/index.ts

eoghanmurray · 2025-06-06T13:29:33Z

When an iframe changes src, do we not record this change and pull in new contents?
Does that bit work ok (i.e. contents would be recorded as being blanked out as far as we are concerned because we can't see them?)

YunFeng0817 · 2025-06-06T18:46:41Z

@eoghanmurray Once the iframe's src is changed, we can not record change to this iframe anymore. I just tested and mutation observer can not even detect the change of this src attribute change.
The iframe in the player will always display the status from before the src attribute changed.
So we can not do much work for this case but at least our code should not fail to stop.

eoghanmurray · 2025-06-13T15:08:00Z

I've checked and the MutationObserver can detect external changes like iframeEl.src = 'xyz.com';
However what I think you are referring to is if the iframe itself changes the frame location using internal document.location = 'redirect.com' ?
Point taken in any case

packages/rrweb/src/record/index.ts

eoghanmurray · 2025-06-13T15:12:52Z

packages/rrweb/test/record.test.ts

+      const iframe = document.createElement('iframe');
+      document.body.appendChild(iframe);
+      await new Promise((resolve) => setTimeout(resolve, 1000));
+      iframe.src = 'https://www.example.com'; // Change the same origin iframe to a cross origin iframe after it's recorded


this should generate a mutation I believe

Co-authored-by: Eoghan Murray <eoghan@getthere.ie>

…me recording error Upgrades posthog-js from 1.282.0 to 1.359.1 in the marketing site. This resolves a DOMException (SecurityError) in PostHog's session recording where rrweb's CrossOriginIframeMirror tries to access removeEventListener on a cross-origin iframe window. Fixed upstream in rrweb-io/rrweb#1695. Also fixes ThemeProvider types for compatibility with updated dependency graph.

@NickBlow

…me recording error (#1173) ## Summary - Bumps `posthog-js` from `1.282.0` to `1.359.1` in the marketing site (`apps/iterate-com`) - Fixes a `DOMException: SecurityError` in PostHog's session recording where rrweb's `CrossOriginIframeMirror` tries to access `removeEventListener` on a cross-origin iframe window — [fixed upstream in rrweb-io/rrweb#1695](rrweb-io/rrweb#1695) - Fixes `ThemeProvider` types that broke due to updated dependency graph (next-themes `PropsWithChildren` resolution) ## Context - **Requested by:** @NickBlow - **Slack thread:** https://iterate-com.slack.com/archives/C09K1CTN4M7/p1773260343748219 - **Agent session:** [attach](https://iterate.iterate.app/terminal?command=opencode+attach+%27http%3A%2F%2Flocalhost%3A4096%27+--session+ses_32178b3baffebgTAPCwm1mzL87+--dir+%2Fhome%2Fiterate%2Fsrc%2Fgithub.com%2Fiterate%2Fmetarepo&autorun=true)    --- > [!NOTE] > **Medium Risk** > Upgrades a third-party analytics/session-replay library (`posthog-js`) with significant transitive dependency changes, which can affect runtime behavior and bundle size. Also tweaks `ThemeProvider` prop typing/rendering, which could impact theming if props/children handling differs. > > **Overview** > Updates the marketing site to use `posthog-js@1.359.1` (from `1.282.0`), pulling in updated transitive deps via `pnpm-lock.yaml` to address session-recording issues. > > Adjusts `ThemeProvider` to accept `React.PropsWithChildren<ThemeProviderProps>` and forward props directly to `next-themes`’ `ThemeProvider` (`<NextThemesProvider {...props} />`) instead of explicitly wrapping `children`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 09fc226. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  Co-authored-by: NickBlow <nick.blow@live.com>

) ## Summary - Wraps handler cleanup calls in `stopRecord()` with try-catch to prevent cross-origin iframe `SecurityError`s from crashing the entire stop process - When an iframe transitions from same-origin to cross-origin (e.g. via redirect), the browser blocks access to its window properties — previously this crashed `stopRecord()` and prevented subsequent handlers from cleaning up - Adopted from [upstream rrweb PR #1695](rrweb-io/rrweb#1695) with a more specific error check (requires both `"from accessing a cross-origin frame"` and `"Blocked a frame with origin"` in the message) ## Test plan - [x] Existing tests pass - [x] Build succeeds (`pnpm build:all`) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

fix: rrweb recorder may throw error when stopping recording after an …

e1bd24d

…iframe becomes cross-origin

Copilot AI review requested due to automatic review settings May 27, 2025 21:07

Copilot AI reviewed May 27, 2025

View reviewed changes

packages/rrweb/src/record/index.ts Show resolved Hide resolved

YunFeng0817 added 2 commits May 27, 2025 14:08

add change set

b9d243e

add failure message check

3528d2d

YunFeng0817 requested a review from Copilot May 27, 2025 21:21

Copilot AI reviewed May 27, 2025

View reviewed changes

packages/rrweb/test/record.test.ts Outdated Show resolved Hide resolved

packages/rrweb/src/record/index.ts Show resolved Hide resolved

YunFeng0817 requested review from Juice10 and eoghanmurray May 27, 2025 21:23

Merge branch 'master' into fix-stop-record

0f851a4

eoghanmurray reviewed Jun 13, 2025

View reviewed changes

packages/rrweb/src/record/index.ts Outdated Show resolved Hide resolved

eoghanmurray reviewed Jun 13, 2025

View reviewed changes

YunFeng0817 and others added 2 commits August 5, 2025 00:28

Update packages/rrweb/src/record/index.ts

475f7b2

Co-authored-by: Eoghan Murray <eoghan@getthere.ie>

remove settimeout

b88b3fe

eoghanmurray approved these changes Aug 5, 2025

View reviewed changes

YunFeng0817 merged commit fc390a9 into master Aug 5, 2025
11 checks passed

This was referenced Aug 5, 2025

Version Packages (alpha) #1605

Merged

Version Packages (alpha) parampavar/rrweb#36

Open

Version Packages (alpha) Spencerx/rrweb#2

Open

This was referenced Aug 31, 2025

Version Packages (alpha) candle-analytics/rrweb#1

Merged

Version Packages (alpha) charlie632/rrweb#3

Open

github-actions bot mentioned this pull request Sep 10, 2025

Version Packages (alpha) QuentinLowe/rrweb#1

Open

github-actions bot mentioned this pull request Sep 23, 2025

Version Packages (alpha) kevinatown/rrweb#2

Open

github-actions bot mentioned this pull request Jul 19, 2023

Version Packages (alpha) suryatmodulus/rrweb#1

Open

This was referenced Oct 30, 2025

Version Packages (alpha) Junify/rrweb#5

Closed

Version Packages (alpha) Junify/rrweb#7

Open

This was referenced May 5, 2025

Version Packages (alpha) Appsurify/rrweb#1

Open

Version Packages (alpha) billyvg/rrweb#1

Open

This was referenced Nov 19, 2025

Version Packages (alpha) rrweb-cloud/rrweb#4

Merged

Version Packages (alpha) rrweb-cloud/rrweb#5

Merged

iterate bot mentioned this pull request Mar 11, 2026

fix(iterate-com): bump posthog-js to 1.359.1 to fix cross-origin iframe recording error iterate/iterate#1173

Merged

erezcor mentioned this pull request Mar 18, 2026

The posthog-js library is throwing error, when user is iddle PostHog/posthog-js#2533

Open

8 tasks

This was referenced Mar 23, 2026

fix: handle cross-origin iframe errors during stop handler cleanup PostHog/posthog-rrweb#145

Merged

Upstream rrweb PRs to assess for adoption (since 2.0.0-alpha.17) PostHog/posthog-rrweb#147

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: rrweb recorder may throw error when stopping recording after an iframe becomes cross-origin#1695

fix: rrweb recorder may throw error when stopping recording after an iframe becomes cross-origin#1695
YunFeng0817 merged 6 commits intomasterfrom
fix-stop-record

YunFeng0817 commented May 27, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

eoghanmurray commented Jun 6, 2025

Uh oh!

YunFeng0817 commented Jun 6, 2025 •

edited

Loading

Uh oh!

eoghanmurray commented Jun 13, 2025

Uh oh!

Uh oh!

eoghanmurray Jun 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

YunFeng0817 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

eoghanmurray commented Jun 6, 2025

Uh oh!

YunFeng0817 commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eoghanmurray commented Jun 13, 2025

Uh oh!

Uh oh!

eoghanmurray Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YunFeng0817 commented May 27, 2025 •

edited

Loading

changeset-bot bot commented May 27, 2025 •

edited

Loading

YunFeng0817 commented Jun 6, 2025 •

edited

Loading