Conversation
🦋 Changeset detectedLatest commit: 39ff229 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a CI hang during the yarn [4/4] Building fresh packages step by skipping Puppeteer's download in key workflows.
- Adds
PUPPETEER_SKIP_DOWNLOAD=trueto install steps in style-check and release workflows - Overrides Puppeteer download base URL and skips download in the ci-cd workflow
- Propagates the skip flag into the compressed-size-action step
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/style-check.yml | Prefixes install steps with PUPPETEER_SKIP_DOWNLOAD=true |
| .github/workflows/release.yml | Adds PUPPETEER_SKIP_DOWNLOAD=true to the install step |
| .github/workflows/ci-cd.yml | Sets PUPPETEER_DOWNLOAD_BASE_URL and skip flag on install; passes skip flag to compressed-size-action |
eoghanmurray
approved these changes
Jun 6, 2025
Juice10
approved these changes
Jun 6, 2025
lewgordon-amplitude
pushed a commit
to lewgordon-amplitude/rrweb
that referenced
this pull request
Jul 7, 2025
…rweb-io#1696) * fix: CI hang forever in the yarn [4/4] Building fresh packages...
lewgordon-amplitude
added a commit
to lewgordon-amplitude/rrweb
that referenced
this pull request
Jul 7, 2025
…rweb-io#1696) * fix: CI hang forever in the yarn [4/4] Building fresh packages...
lewgordon-amplitude
added a commit
to lewgordon-amplitude/rrweb
that referenced
this pull request
Jul 7, 2025
…rweb-io#1696) * fix: CI hang forever in the yarn [4/4] Building fresh packages...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure why the CI is stuck at yarn [4/4] Building fresh packages step forever now but not before
After I apply the workaround in puppeteer/puppeteer#12094 (comment), the CI starts to work.