This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Merged
Conversation
Contributor
Not particularly, no. I think I did it at two different times and didn't remember that I had done it for the other one, so it was just duplicated. |
Member
Author
Yeah actually it looks like it was ported way before and we didnt notice when we ported the rest |
* update cartographer configuration files for cartographer 0.3.0 * more config files updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@clalancette as you created these files originally:
depth_traits.handdepth_traits.hppseem to be identical in both packages (ros2 style fixups aside). Do you remember the motivation for duplicating them rather than providing it in a way that can be consumed by both packages?Connects to: ros2/ros2#481