Merged
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mjcarroll
approved these changes
Mar 11, 2019
Member
mjcarroll
left a comment
There was a problem hiding this comment.
Using just ament_lint_cmake seems reasonable to me in this case.
jacobperron
reviewed
Mar 11, 2019
| set(INCLUDE_INSTALL_DIR include/) | ||
| set(SYSCONFIG_INSTALL_DIR share/${PROJECT_NAME}) | ||
|
|
||
| find_package(ament_cmake_test REQUIRED) |
Member
There was a problem hiding this comment.
This command sets the build BUILD_TESTING flag.
If we remove it, we should do something else to enable testing (I think enable_testing()).
Member
There was a problem hiding this comment.
There is much more logic to it than just calling enable_testing(): see https://github.com/ament/ament_cmake/blob/207a07b72af1e5a780887d7c2268df57ef456af3/ament_cmake_test/ament_cmake_test-extras.cmake#L17-L37 so I don't think duplicating that logic makes sense.
Member
Author
There was a problem hiding this comment.
e4ee571 applies suggestion from #90 (comment)
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mjcarroll
approved these changes
Mar 12, 2019
mjcarroll
pushed a commit
that referenced
this pull request
Mar 12, 2019
* remove unecessary ament_cmake_test Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * remove ament_lint_auto dependency Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * add back ament_cmake_test with comment Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
10 tasks
ryanewel
pushed a commit
to aws-ros-dev/sros2
that referenced
this pull request
Jun 12, 2019
* remove unecessary ament_cmake_test Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * remove ament_lint_auto dependency Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * add back ament_cmake_test with comment Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #90
ament_cmake_testfind_package call.ament_lint_autoaltogether and only depends onament_cmake_lint_cmake.Second commit is more subjective, as this is not an ament package, each linter has to be called explicitly. At that point it seems that relying on
ament_lint_autoloses its benefits while adding dependencies and CMake code. As this package is meant to only provide pure cmake macros it looks likeament_lint_cmakeis the only linter it will need going forward .Happy to revert the second commit if the ament_lint_auto approach is preferred.