Skip to content

Add BaseImpl to rosidl_pycommon.interface_base_classes#912

Merged
ahcorde merged 1 commit intoros2:rollingfrom
InvincibleRMC:fix-Impl
Nov 10, 2025
Merged

Add BaseImpl to rosidl_pycommon.interface_base_classes#912
ahcorde merged 1 commit intoros2:rollingfrom
InvincibleRMC:fix-Impl

Conversation

@InvincibleRMC
Copy link
Copy Markdown
Contributor

@InvincibleRMC InvincibleRMC commented Oct 7, 2025

Description

Expands on #887 by providing a base class for Impl helper and adding another generic argument to BaseAction

Is this user-facing behavior change?

The public facing api should remain the same.

Did you use Generative AI?

Additional Information

@InvincibleRMC
Add BaseImpl
0df7afb 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC mentioned this pull request Oct 7, 2025
Merged
@kscottz kscottz added the help wanted Extra attention is needed label Oct 16, 2025
@InvincibleRMC
Copy link
Copy Markdown
Contributor Author

InvincibleRMC commented Nov 6, 2025 •
edited
Loading

@mjcarroll I assume you have just been super busy with ROS CON and that you don't need anything from me.

fujitatomoya
fujitatomoya reviewed Nov 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Adding a generic Impl type to BaseAction to improve typing and structure without affecting runtime behavior or APIs.

@mjcarroll
Copy link
Copy Markdown
Member

mjcarroll commented Nov 7, 2025

Pulls: #912
Gist: https://gist.githubusercontent.com/mjcarroll/d7915640453c60fc4d2c0038b0a27594/raw/5ace04575130991479c72ff0b74480c00664059e/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17417

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Copy Markdown
Contributor Author

InvincibleRMC commented Nov 8, 2025

@mjcarroll did you build it with ros2/rosidl_python#241 as well?

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Nov 9, 2025

i do not think so, let me rerun the CI with it.

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Nov 9, 2025

Pulls: #912, ros2/rosidl_python#241
Gist: https://gist.githubusercontent.com/fujitatomoya/9f441816f19ee6d405c62125f9726ab5/raw/11c1492eb07fa5b031ba74a1fabf2a2426ca17d9/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_pycommon rosidl_generator_py
TEST args: --packages-above rosidl_pycommon rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17423

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit a27828d into ros2:rolling Nov 10, 2025
3 checks passed
@bjsowa bjsowa mentioned this pull request Feb 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@mjcarroll mjcarroll

Labels

help wanted Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@InvincibleRMC @mjcarroll @fujitatomoya @ahcorde @kscottz