add object representation and conversion from ast#326
Conversation
sloretz
left a comment
There was a problem hiding this comment.
Partial review. I have some questions about the definitions. With those answers I'll be better able to review the parser.
|
Just another CI after the changes: |
|
Sill good with the |
sloretz
left a comment
There was a problem hiding this comment.
LGTM for now with a minor fix. There are limitations that should be ticketed like includes in modules and different constants in different messages. Tests with IDL files that are acceptable to the grammar but illogical, like a boolean constant being assigned a string value, would be good too, but that can be ticketed rather than blocking the remaining PRs.
|
Thanks. I created #329 for the followup improvements. Squashing the commits before the merge... |
202eb24 to
1d934b2
Compare
That is very suspicious because the PR job has no way of pulling the |
9b6076f to
49b1eaa
Compare
|
Full build: |
|
@ros-pull-request-builder retest this please |
|
Waiting for the |
49b1eaa to
8219e66
Compare
8219e66 to
363cade
Compare
|
49d24f2 to
edfcae2
Compare
This is the fifth PR integrating #298 step-by-step.
Builds on top of #325. Needs ros2/ci#220.
After lark parses any input file the AST is converted to an object representation (which will later be passed into the message generator templates).
Linux CI: